Bug 1937991: CNI: Lookup offending interface on NetlinkError #482
Conversation
|
@dulek: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold I need to test this. |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
approved
dulek
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@dulek: This pull request references Bugzilla bug 1937991, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gcheresh@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dulek
force-pushed
the
fix-netlink-error
branch
5 times, most recently
from
643671d
to
b6c193f
Compare
|
/test images |
dulek
force-pushed
the
fix-netlink-error
branch
3 times, most recently
from
c199fe9
to
b7c7ede
Compare
|
Okay, this version seems to work in both cri-o modes. @MaysaMacedo, @luis5tb, @gryf, can you please take a look. It's fragile code, so more diligent look is welcomed. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
dulek
force-pushed
the
fix-netlink-error
branch
from
b7c7ede
to
61e371b
Compare
The infamous `NetlinkError: (17, 'File exists')` started to bug us again due to changes in when cri-o is deleting network namespaces. This patch is an ultimate brute-force attempt to fix the problem. The idea is that on NetlinkError kuryr-daemon will iterate over *all* network namespaces in the system and delete interfaces that have the conflicting VLAN ID. Closes-Bug: 1892388 Change-Id: I6672ed0e0db99a91b68cc4d9e74a33d8a9bcf0ca
dulek
force-pushed
the
fix-netlink-error
branch
from
61e371b
to
284ef78
Compare
dulek
requested review from
MaysaMacedo,
gryf and
luis5tb
and removed request for
celebdor and
yboaron
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, luis5tb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dulek: All pull requests linked via external trackers have merged: Bugzilla bug 1937991 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The infamous
NetlinkError: (17, 'File exists')started to bug us againdue to changes in when cri-o is deleting network namespaces. This patch
is an ultimate brute-force attempt to fix the problem. The idea is that
on NetlinkError kuryr-daemon will iterate over all network namespaces
in the system and delete interfaces that have the conflicting VLAN ID.
Closes-Bug: 1892388
Change-Id: I6672ed0e0db99a91b68cc4d9e74a33d8a9bcf0ca