[release-4.6] Bug 1968418: Fixing bug, Kuryr-Controller crashes when it's missing the status #519
Conversation
This patch is fixing the bug in which was problem after the status field is deleted, kuryr-controller is crashing because of it. So we need to check if status field is missing and add it to the crd. Also I add there fixes of another parts of code where probably in the future could be similar problem is some parts of the CRD would be missing. Closes-Bug: #1921109 Change-Id: Ib195aa4389e310354f163d3ba474eddea18c4f51
openshift-ci
bot
added
bugzilla/severity-medium
|
@dulek: This pull request references Bugzilla bug 1968418, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/hold I bet I should test this first, the cherry-pick wasn't trivial. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/bugzilla refresh |
|
@dulek: This pull request references Bugzilla bug 1968418, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@dulek: This pull request references Bugzilla bug 1968418, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
/test images |
dulek
force-pushed
the
cherry-pick-501-to-release-4.6
branch
from
342c28a
to
bab929b
Compare
|
Ha, good I tested this, I made quite a mistake resolving conflicts. |
If we're in the process of handling a KuryrLoadBalancer event and somebody's tries to delete the `.status` field there, any update we do on `.status` will result in 422 Unprocessable Entity returned from K8s API. There's no sense in failing kuryr-controller in that case as the update should trigger another event and Kuryr should be able to recover by discovering all the resources and filling the status again. This commit fixes that by making sure in such situation we stop processing the event and make the handler wait for the next one. As a consuequence KLB's 404 returned from patch operations is also handled as hard stop for further processing of the KuryrLoadBalancer as there's no point in creating or deleting Octavia resources if the LB is destined to be cascade deleted. Change-Id: I5dabded04302268e2c5c25f6c31a5619cd0c28e1 Closes-Bug: 1921109
dulek
force-pushed
the
cherry-pick-501-to-release-4.6
branch
from
bab929b
to
f9d2018
Compare
|
/hold cancel Alright, this seems to work now. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mfojtik
added
the
cherry-pick-approved
|
[patch-manager] 🚀 Approved for z-stream by score: 0.70 approved |
|
@dulek: All pull requests linked via external trackers have merged: Bugzilla bug 1968418 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry pick of #501.