Bug 1972631: Workaround OVN bug causing subports to be DOWN

[dulek]

Neutron should make a subport that is already attached to a trunk ACTIVE
immediately. Unfortunately there seems to be an OVN bug causing an event
triggering this to be lost, leaving the port in DOWN state forever. This
is a disaster for Kuryr, because we can't proceed to wire the pods in
such case.

This commit attempts to workaround this by making Kuryr reattach the
ports that are in DOWN state for more than 90 seconds after they're
plugged.

Change-Id: If9a3968d68dced588614cd5521d4a111e78d435f

[openshift-ci]

@dulek: This pull request references Bugzilla bug 1972631, which is invalid:

• expected dependent Bugzilla bug 1969397 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1972631: Workaround OVN bug causing subports to be DOWN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MaysaMacedo,dulek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci]

@openshift-bot: This pull request references Bugzilla bug 1972631, which is invalid:

• expected dependent Bugzilla bug 1969397 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

/bugzilla refresh

[openshift-ci]

@dulek: This pull request references Bugzilla bug 1972631, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1969397 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1969397 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
• bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dulek: All pull requests linked via external trackers have merged:

• openshift/kuryr-kubernetes#525

Bugzilla bug 1972631 has been moved to the MODIFIED state.

In response to this:

Bug 1972631: Workaround OVN bug causing subports to be DOWN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@dulek: #525 failed to apply on top of branch "release-4.6":

Applying: Workaround OVN bug causing subports to be DOWN
Using index info to reconstruct a base tree...
M	kuryr_kubernetes/controller/drivers/base.py
M	kuryr_kubernetes/controller/drivers/nested_macvlan_vif.py
M	kuryr_kubernetes/controller/drivers/nested_vlan_vif.py
M	kuryr_kubernetes/controller/drivers/neutron_vif.py
M	kuryr_kubernetes/controller/drivers/sriov.py
M	kuryr_kubernetes/controller/drivers/vif_pool.py
M	kuryr_kubernetes/controller/handlers/kuryrnetwork.py
M	kuryr_kubernetes/controller/handlers/kuryrnetwork_population.py
M	kuryr_kubernetes/controller/handlers/kuryrnetworkpolicy.py
M	kuryr_kubernetes/controller/handlers/kuryrport.py
M	kuryr_kubernetes/controller/handlers/lbaas.py
M	kuryr_kubernetes/controller/handlers/loadbalancer.py
A	kuryr_kubernetes/controller/handlers/machine.py
M	kuryr_kubernetes/controller/handlers/namespace.py
M	kuryr_kubernetes/controller/handlers/pod_label.py
M	kuryr_kubernetes/controller/handlers/vif.py
M	kuryr_kubernetes/handlers/retry.py
M	kuryr_kubernetes/tests/unit/controller/handlers/test_kuryrport.py
M	kuryr_kubernetes/tests/unit/handlers/test_retry.py
Falling back to patching base and 3-way merge...
Auto-merging kuryr_kubernetes/tests/unit/handlers/test_retry.py
Auto-merging kuryr_kubernetes/tests/unit/controller/handlers/test_kuryrport.py
Auto-merging kuryr_kubernetes/handlers/retry.py
Auto-merging kuryr_kubernetes/controller/handlers/vif.py
Auto-merging kuryr_kubernetes/controller/handlers/pod_label.py
Auto-merging kuryr_kubernetes/controller/handlers/namespace.py
CONFLICT (modify/delete): kuryr_kubernetes/controller/handlers/machine.py deleted in HEAD and modified in Workaround OVN bug causing subports to be DOWN. Version Workaround OVN bug causing subports to be DOWN of kuryr_kubernetes/controller/handlers/machine.py left in tree.
Auto-merging kuryr_kubernetes/controller/handlers/loadbalancer.py
Auto-merging kuryr_kubernetes/controller/handlers/lbaas.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/controller/handlers/lbaas.py
Auto-merging kuryr_kubernetes/controller/handlers/kuryrport.py
Auto-merging kuryr_kubernetes/controller/handlers/kuryrnetworkpolicy.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/controller/handlers/kuryrnetworkpolicy.py
Auto-merging kuryr_kubernetes/controller/handlers/kuryrnetwork_population.py
Auto-merging kuryr_kubernetes/controller/handlers/kuryrnetwork.py
Auto-merging kuryr_kubernetes/controller/drivers/vif_pool.py
Auto-merging kuryr_kubernetes/controller/drivers/sriov.py
Auto-merging kuryr_kubernetes/controller/drivers/neutron_vif.py
Auto-merging kuryr_kubernetes/controller/drivers/nested_vlan_vif.py
Auto-merging kuryr_kubernetes/controller/drivers/nested_macvlan_vif.py
Auto-merging kuryr_kubernetes/controller/drivers/base.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Workaround OVN bug causing subports to be DOWN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.