Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #537

Merged
merged 5 commits into from Jun 30, 2021
Merged

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #537

merged 5 commits into from Jun 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2021

No description provided.

dulek and others added 5 commits June 24, 2021 13:07
@dulek
Add original exception to log about dead component
1e2e5b1 
This commit make sure we save the exception that caused a handler to be
dead and log it when printing "Component X is dead".

Change-Id: Idcc71a60b2fe448287f2e2d1a0747657c12a5719
@dulek
Use correct logger when setting pyroute2 log level
55f1c30 
Change-Id: Ia74bdf3f770da465596380c6ea80a603a422977a
@openstack-gerrit
Merge "Add original exception to log about dead component"
e92008c
@openstack-gerrit
Merge "Use correct logger when setting pyroute2 log level"
1874e59
Merge https://opendev.org/openstack/kuryr-kubernetes:master into master
fb7050c
@openshift-ci openshift-ci bot requested review from gryf and luis5tb June 30, 2021 07:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

Hi @kuryr-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2021
@dulek
Copy link
Contributor

dulek commented Jun 30, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2021
@dulek
Copy link
Contributor

dulek commented Jun 30, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, kuryr-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit a639c5f into openshift:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gryf gryf Awaiting requested review from gryf

@luis5tb luis5tb Awaiting requested review from luis5tb

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dulek @openshift-merge-robot