gracefully exit daemonserver before registry exit #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the registry manager is stopped while daemon server is still processing requests, the pending requests fail and result in resource leaks in ovs. With this change, we wait for DaemonServer to finish processing before shutting down the registry manager. Closes-bug: 1856109 Change-Id: I37498ae7bf6a8b4b14afe53d1af3fb8823d589cf Signed-off-by: Yash Gupta <y.gupta@samsung.com> Co-Authored-By: Michał Dulko <mdulko@redhat.com>
Change-Id: Iee5db357dd334a42d5b07177e463a56e75a6c700
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, gryf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the registry manager is stopped while daemon server is still
processing requests, the pending requests fail and result in resource
leaks in ovs.
With this change, we wait for DaemonServer to finish processing before
shutting down the registry manager.
Closes-bug: 1856109
Change-Id: I37498ae7bf6a8b4b14afe53d1af3fb8823d589cf
Signed-off-by: Yash Gupta y.gupta@samsung.com
Co-Authored-By: Michał Dulko mdulko@redhat.com