Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1983107: Fix KLB conversion from annotations #541

Merged
merged 1 commit into from Jul 30, 2021

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Jul 20, 2021

There's a corner case in conversion of Endpoints and Services
annotations into KuryrLoadBalancer CRDs in which the endpointSlices
field is ommitted causing a kuryr-controller restart. While it seems to
be harmless as after restart EndpointsHandler will kick in and add the
missing field, it's still worth to fix the migration.

This commit does so by making sure endpointSlices object is added to the
KuryrLoadbalancer spec.

Change-Id: I746c5e32f57491e94b7c04639bd9631f3a3fa6fb

There's a corner case in conversion of Endpoints and Services
annotations into KuryrLoadBalancer CRDs in which the endpointSlices
field is ommitted causing a kuryr-controller restart. While it seems to
be harmless as after restart EndpointsHandler will kick in and add the
missing field, it's still worth to fix the migration.

This commit does so by making sure endpointSlices object is added to the
KuryrLoadbalancer spec.

Change-Id: I746c5e32f57491e94b7c04639bd9631f3a3fa6fb
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@dulek: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix KLB conversion from annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from celebdor and gryf July 20, 2021 12:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@dulek dulek changed the title Fix KLB conversion from annotations Bug 1983107: Fix KLB conversion from annotations Jul 20, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@dulek: This pull request references Bugzilla bug 1983107, which is invalid:

  • expected dependent Bugzilla bug 1983102 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1983107: Fix KLB conversion from annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 20, 2021
@dulek
Copy link
Contributor Author

dulek commented Jul 20, 2021

/test images

@dulek
Copy link
Contributor Author

dulek commented Jul 20, 2021

/hold

Let me test this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@dulek
Copy link
Contributor Author

dulek commented Jul 20, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@dulek: This pull request references Bugzilla bug 1983107, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1983102 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1983102 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 20, 2021
@openshift-ci openshift-ci bot requested a review from eurijon July 20, 2021 16:45
@dulek
Copy link
Contributor Author

dulek commented Jul 20, 2021

/hold cancel

This seems to work.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@MaysaMacedo
Copy link
Contributor

/lgtm

nice!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aravindhp aravindhp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0063daa into openshift:release-4.6 Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@dulek: All pull requests linked via external trackers have merged:

Bugzilla bug 1983107 has been moved to the MODIFIED state.

In response to this:

Bug 1983107: Fix KLB conversion from annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants