New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1983107: Fix KLB conversion from annotations #541
Bug 1983107: Fix KLB conversion from annotations #541
Conversation
There's a corner case in conversion of Endpoints and Services annotations into KuryrLoadBalancer CRDs in which the endpointSlices field is ommitted causing a kuryr-controller restart. While it seems to be harmless as after restart EndpointsHandler will kick in and add the missing field, it's still worth to fix the migration. This commit does so by making sure endpointSlices object is added to the KuryrLoadbalancer spec. Change-Id: I746c5e32f57491e94b7c04639bd9631f3a3fa6fb
@dulek: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dulek: This pull request references Bugzilla bug 1983107, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test images |
/hold Let me test this. |
/bugzilla refresh |
@dulek: This pull request references Bugzilla bug 1983107, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel This seems to work. |
/lgtm nice! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dulek: All pull requests linked via external trackers have merged: Bugzilla bug 1983107 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There's a corner case in conversion of Endpoints and Services
annotations into KuryrLoadBalancer CRDs in which the endpointSlices
field is ommitted causing a kuryr-controller restart. While it seems to
be harmless as after restart EndpointsHandler will kick in and add the
missing field, it's still worth to fix the migration.
This commit does so by making sure endpointSlices object is added to the
KuryrLoadbalancer spec.
Change-Id: I746c5e32f57491e94b7c04639bd9631f3a3fa6fb