Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1995013: Remove ep_slices from klb on endpoint delete event #550

Merged
merged 1 commit into from Oct 14, 2021
Merged

[release-4.8] Bug 1995013: Remove ep_slices from klb on endpoint delete event #550

merged 1 commit into from Oct 14, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #549

/assign zerodayz

@zerodayz
Remove ep_slices from klb on endpoint delete event
0789ddd 
Closes-Bug: 1939512

Change-Id: Ia0a9ae82c46a43a64c916194a272f0a85618fa34
(cherry picked from commit 164095b)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 18, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@openshift-cherrypick-robot: Bugzilla bug 1938282 has been cloned as Bugzilla bug 1995013. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1995013: Remove ep_slices from klb on endpoint delete event

In response to this:

[release-4.8] Bug 1938282: Remove ep_slices from klb on endpoint delete event

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1938282: Remove ep_slices from klb on endpoint delete event [release-4.8] Bug 1995013: Remove ep_slices from klb on endpoint delete event Aug 18, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1995013, which is invalid:

  • expected dependent Bugzilla bug 1938282 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1995013: Remove ep_slices from klb on endpoint delete event

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Aug 18, 2021

Now the 4.9 BZ needs to wait to be verified by the QE.

@zerodayz
Copy link
Contributor

Thank you Michal 🍾 I am looking forward to the time when I don't have to delete endpoints manually from the klb 👍

@zerodayz
Copy link
Contributor

zerodayz commented Sep 6, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2021

@zerodayz: This pull request references Bugzilla bug 1995013, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1938282 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1938282 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eurijon September 6, 2021 22:42
@zerodayz
Copy link
Contributor

zerodayz commented Sep 6, 2021

@dulek 4.9 BZ moved to VERIFIED.

@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@hardys
Copy link

hardys commented Sep 16, 2021

[patch-manager] Approving for cherry-pick with a score of 0.70

@hardys hardys added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 16, 2021
@hardys
Copy link

hardys commented Sep 16, 2021

[patch-manager] The test failures look real, removing cherry-pick-approved - @zerodayz can you take a look please?

ERROR: Cannot install oslo.db because these package versions have conflicting dependencies.
The conflict is caused by:
    sqlalchemy-migrate 0.13.0 depends on Tempita>=0.4
    The user requested (constraint) tempita===0.5.2

@hardys hardys removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 16, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@zerodayz
Copy link
Contributor

Hi @hardys, will definitely check. It doesn't seems to be related to the change, rather something changed for the test. I have pinged the kuryr dev team.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@dulek
Copy link
Contributor

dulek commented Sep 17, 2021

I'll take a look too.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@hardys
Copy link

hardys commented Sep 17, 2021

/hold until unit/verify failures are resolved

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2021
@zerodayz
Copy link
Contributor

Fix for the tests #567, need to wait until its merged to 4.8 before moving on with this.

@dhellmann
Copy link
Contributor

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped for today

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

2 similar comments
@dhellmann
Copy link
Contributor

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped for today

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@dhellmann
Copy link
Contributor

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped for today

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@MaysaMacedo
Copy link
Contributor

/retest

@dulek
Copy link
Contributor

dulek commented Oct 6, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@dulek
Copy link
Contributor

dulek commented Oct 6, 2021

Looks like CI works fine now.

@dulek
Copy link
Contributor

dulek commented Oct 13, 2021

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 13, 2021
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 15fa4c4 into openshift:release-4.8 Oct 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1995013 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1995013: Remove ep_slices from klb on endpoint delete event

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis5tb luis5tb Awaiting requested review from luis5tb

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@MaysaMacedo MaysaMacedo

@zerodayz zerodayz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @dulek @zerodayz @MaysaMacedo @hardys @openshift-bot @dhellmann @sdodson @openshift-merge-robot