Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2002548: Fix health checks on large scale environments #558

Conversation

zerodayz
Copy link
Contributor

@zerodayz zerodayz commented Sep 9, 2021

With large scale environments >3k ports, the health checks fails due to the slowness in API response from OpenStack.

This only changes the checks so that they use quota client instead.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@zerodayz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix health checks on large scale environments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zerodayz zerodayz changed the title Fix health checks on large scale environments Bug 2002548: Fix health checks on large scale environments Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@zerodayz: An error was encountered querying GitHub for users with public email (juriarte@redhat.com) for bug 2002548 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2002548: Fix health checks on large scale environments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dulek and yboaron September 9, 2021 08:01
@zerodayz
Copy link
Contributor Author

zerodayz commented Sep 9, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@zerodayz: This pull request references Bugzilla bug 2002548, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 9, 2021
@openshift-ci openshift-ci bot requested a review from eurijon September 9, 2021 08:45
@zerodayz zerodayz force-pushed the fix-health-checks-large-scale branch 2 times, most recently from 1675400 to 3382fa6 Compare September 9, 2021 09:16
With large scale environments >3k ports, the health checks fails due to
te slowness in API response from OpenStack.

This only changes the checks so that they use quota client instead.
@zerodayz zerodayz force-pushed the fix-health-checks-large-scale branch from 3382fa6 to 4126bd3 Compare September 9, 2021 10:26
@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, zerodayz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit fa5d1af into openshift:release-3.11 Sep 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2021

@zerodayz: All pull requests linked via external trackers have merged:

Bugzilla bug 2002548 has been moved to the MODIFIED state.

In response to this:

Bug 2002548: Fix health checks on large scale environments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants