Bug 2028396: Make completed Pods Ports reusable

[MaysaMacedo]

When the Pod has status Completed it has finalized
its job, consequently it's expected that Kuryr will
reclycle the Neutron Ports associated with it to be
used by other Pods. However, Kuryr is considering
Completed Pods as not scheduled and the event is skipped.
This commit fixes the issue by ensuring that Completed
Pods Ports recycle is done before checking for Scheduled
Pods.

Closes-Bug: #1945680
Change-Id: I23e7901fb016d59fa76762d1f24fee47974e72df

[openshift-ci]

@MaysaMacedo: This pull request references Bugzilla bug 2028396, which is invalid:

• expected dependent Bugzilla bug 2013017 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2028396: Make completed Pods Ports reusable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

Manual cherry-pick of #600

[MaysaMacedo]

/bugzilla refresh

[openshift-ci]

@MaysaMacedo: This pull request references Bugzilla bug 2028396, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2022722 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2022722 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
• bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

/approve
/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MaysaMacedo,dulek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eurijon]

/label cherry-pick-approved

[eurijon]

/label cherry-pick-approved

[openshift-ci]

@MaysaMacedo: All pull requests linked via external trackers have merged:

• openshift/kuryr-kubernetes#608

Bugzilla bug 2028396 has been moved to the MODIFIED state.

In response to this:

Bug 2028396: Make completed Pods Ports reusable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/cherry-pick release 4.6

[openshift-cherrypick-robot]

@MaysaMacedo: cannot checkout release 4.6: error checking out release 4.6: exit status 1. output: error: pathspec 'release 4.6' did not match any file(s) known to git

In response to this:

/cherry-pick release 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MaysaMacedo]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@MaysaMacedo: #608 failed to apply on top of branch "release-4.6":

Applying: Make completed Pods Ports reusable
Using index info to reconstruct a base tree...
M	kuryr_kubernetes/controller/handlers/kuryrport.py
M	kuryr_kubernetes/controller/handlers/vif.py
M	kuryr_kubernetes/tests/unit/controller/handlers/test_vif.py
M	kuryr_kubernetes/tests/unit/test_utils.py
M	kuryr_kubernetes/utils.py
Falling back to patching base and 3-way merge...
Auto-merging kuryr_kubernetes/utils.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/utils.py
Auto-merging kuryr_kubernetes/tests/unit/test_utils.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/tests/unit/test_utils.py
Auto-merging kuryr_kubernetes/tests/unit/controller/handlers/test_vif.py
Auto-merging kuryr_kubernetes/controller/handlers/vif.py
Auto-merging kuryr_kubernetes/controller/handlers/kuryrport.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Make completed Pods Ports reusable
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-controller-container-v4.7.0-202304290014.p0.g72de60e.assembly.stream for distgit kuryr-controller.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build kuryr-cni-container-v4.7.0-202304290014.p0.g72de60e.assembly.stream for distgit kuryr-cni.
All builds following this will include this PR.