New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2088444: Add leftover resources protection #674
Bug 2088444: Add leftover resources protection #674
Conversation
@MaysaMacedo: This pull request references Bugzilla bug 2088444, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
Okay, previous failure was just quota lease problem. |
/retest |
/retest |
For Neutron networks and subnets, add identifier (which origins from tags) to the description field as a workaround for inability for create tagged resources in atomic way. This change might be reverted when Neutron gain such ability. Depends-On: https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/841107 Change-Id: I1750a0b6ae569752b44a4fe682288686868450fe
There was already introduced port cleanup function, so in this patch there is new function introduced for cleaning up unused networks and subnets for whole deployment, by using identifier from description. Change-Id: Ia11e8953fab3f9cd8f6598f9da94daae324b1bf8
4dca49b
to
012004d
Compare
I replaced the commits with the ones actually merge upstream. |
/lgtm |
/retest |
/retest |
Generator doesn't have lenght available, so we must convert it to list instead. Change-Id: Ia979894de405bba83952284a1df714753d62494b
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-openstack-kuryr Overriding as the e2e conformance and openstack tests are passing. |
@MaysaMacedo: Overrode contexts on behalf of MaysaMacedo: ci/prow/e2e-openstack-kuryr In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@MaysaMacedo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@MaysaMacedo: All pull requests linked via external trackers have merged: Bugzilla bug 2088444 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.