Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2088444: Add leftover resources protection #674

Merged

Conversation

MaysaMacedo
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2022

@MaysaMacedo: This pull request references Bugzilla bug 2088444, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

Bug 2088444: Add leftover resources protection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from eurijon, dulek and gryf June 21, 2022 11:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@dulek
Copy link
Contributor

dulek commented Jun 21, 2022

/retest

@dulek
Copy link
Contributor

dulek commented Jun 21, 2022

Okay, previous failure was just quota lease problem.

@MaysaMacedo
Copy link
Contributor Author

/retest
installation failure

@dulek
Copy link
Contributor

dulek commented Jun 22, 2022

/retest

gryf added 2 commits June 22, 2022 13:35
For Neutron networks and subnets, add identifier (which origins from
tags) to the description field as a workaround for inability for create
tagged resources in atomic way. This change might be reverted when
Neutron gain such ability.

Depends-On: https://review.opendev.org/c/openstack/kuryr-tempest-plugin/+/841107
Change-Id: I1750a0b6ae569752b44a4fe682288686868450fe
There was already introduced port cleanup function, so in this patch
there is new function introduced for cleaning up unused networks and
subnets for whole deployment, by using identifier from description.

Change-Id: Ia11e8953fab3f9cd8f6598f9da94daae324b1bf8
@dulek dulek force-pushed the add-leftover-resources-protection branch from 4dca49b to 012004d Compare June 22, 2022 11:36
@dulek
Copy link
Contributor

dulek commented Jun 22, 2022

I replaced the commits with the ones actually merge upstream.

@dulek
Copy link
Contributor

dulek commented Jun 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2022
@MaysaMacedo
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD c4f89c9 and 8 for PR HEAD 012004d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD c4f89c9 and 7 for PR HEAD 012004d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c4f89c9 and 6 for PR HEAD 012004d in total

@dulek
Copy link
Contributor

dulek commented Jun 23, 2022

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD c9b41b9 and 5 for PR HEAD 012004d in total

Generator doesn't have lenght available, so
we must convert it to list instead.

Change-Id: Ia979894de405bba83952284a1df714753d62494b
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@dulek
Copy link
Contributor

dulek commented Jun 23, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@MaysaMacedo
Copy link
Contributor Author

/override ci/prow/e2e-openstack-kuryr

Overriding as the e2e conformance and openstack tests are passing.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@MaysaMacedo: Overrode contexts on behalf of MaysaMacedo: ci/prow/e2e-openstack-kuryr

In response to this:

/override ci/prow/e2e-openstack-kuryr

Overriding as the e2e conformance and openstack tests are passing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@MaysaMacedo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 66c0cec into openshift:master Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@MaysaMacedo: All pull requests linked via external trackers have merged:

Bugzilla bug 2088444 has been moved to the MODIFIED state.

In response to this:

Bug 2088444: Add leftover resources protection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants