Openshift rebase #89
Merged
Openshift rebase #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains spec file for nested-dpdk case in kuryr-kubernetes. It describes how to setup and use it. Change-Id: I4cb83d49b56b16382b00edacf8cfbdd814f0d504 Implements: blueprint nested-dpdk-support Signed-off-by: Danil Golov <d.golov@samsung.com>
Default vif should use the ifname supplied by CNI ADD request, instead of using a fixed value (This helps to work with multus cni as well) This is kind of a hack, as the vifs dict still uses the DEFAULT_IFNAME for keeping track of the default vif, but changing that would require some refactoring (as we do not know the requested ifname in controller, it is only known when kuryr-cni-daemon tries to plug the vif) Closes-Bug: 1852380 Change-Id: I4b185b8ca811793a7dfd459d2d89346119709acc Signed-off-by: Yash Gupta <y.gupta@samsung.com>
Allowing user to configure the addtional_ifname_prefix allows kuryr-kubernetes to work more smoothly with other CNI plugins (when using multus or multiple chained CNIs for example). Change-Id: I4ce35e939c1564c1ba0bd2ae55c09fa24a35c9ed Signed-off-by: Yash Gupta <y.gupta@samsung.com>
Change-Id: I6c847a67468d2ed5e2b9efb76fd3c35842c71191
openshift-ci-robot
added
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MaysaMacedo
pushed a commit
to MaysaMacedo/kuryr-kubernetes-1
that referenced
this pull request
Jul 1, 2021
configure endpoints to expose openshift-sdn metrics to Prometheus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.