[OCPCLOUD-1187] Include Azure support to external CCM selection #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
changed the title
JoelSpeed
reviewed
Jun 15, 2021
Danil-Grigorev
force-pushed
the
external-azure
branch
from
5894ee0
to
f3f36cc
Compare
JoelSpeed
reviewed
Jun 15, 2021
Danil-Grigorev
force-pushed
the
external-azure
branch
from
f3f36cc
to
4dd63e7
Compare
JoelSpeed
reviewed
Jun 16, 2021
Danil-Grigorev
force-pushed
the
external-azure
branch
2 times, most recently
from
2a1707a
to
05d070b
Compare
|
/retest |
|
/lgtm |
Danil-Grigorev
force-pushed
the
external-azure
branch
from
05d070b
to
0615dc5
Compare
|
/lgtm Danil and I had some discussion yesterday about the bindata and podnetworkconnectivity check yaml, seems that the verify job just ensures that the files are synced with the vendor folder, which has been updated to include the latest changes in openshift/api. Looking for an owner to confirm that copying them was the right thing to do |
|
/approve |
openshift-ci
bot
added
the
approved
- Update bindata for network crd
Danil-Grigorev
force-pushed
the
external-azure
branch
from
0615dc5
to
88b73d2
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev, JoelSpeed, soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support on Azure and AzureStackHub for IsCloudProviderExternal helper. Depends on api change to be merged first: openshift/api#860