introduces a startup monitor #1130
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
p0lyn0mial
force-pushed
the
startup-monitor
branch
7 times, most recently
from
dbbc6bd
to
b508419
Compare
| terminationGracePeriodSeconds: 5 | ||
| priorityClassName: system-node-critical | ||
| tolerations: | ||
| - operator: "Exists" |
There was a problem hiding this comment.
no idea. Better remove it instead of cargo culting :)
pkg/operator/staticpod/startupmonitor/assets/startup-monitor-pod.yaml
Outdated
Show resolved
Hide resolved
| - --target-name=kube-apiserver | ||
| - --manifests-dir=/etc/kubernetes/manifests | ||
| - --resource-dir=/etc/kubernetes/static-pod-resources | ||
| - --revision=REVISION |
There was a problem hiding this comment.
we really still have REVISION and not {{.Revision}} ?
There was a problem hiding this comment.
yeah, the REVISION is replaced by the installer-pod
There was a problem hiding this comment.
at some point we should clean up :)
| } | ||
|
|
||
| // step 1: create last known good revision | ||
| if err := m.io.Symlink(revisionedTargetManifestPath, m.lastKnownGoodManifestDstPath()); err != nil { |
There was a problem hiding this comment.
isn't there a force variant for this? I always thought symlink update is atomic.
p0lyn0mial
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
sttts
force-pushed
the
startup-monitor
branch
3 times, most recently
from
d03338f
to
0c3516b
Compare
|
/lgtm |
|
@p0lyn0mial: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Needs squashing. Then lgtm. /approve |
openshift-ci
bot
added
the
approved
The main purpose of the new app is to provide a fallback mechanism that will make the operand to revert to the last healthy revision when the new revision fails. The fallback mechanism is opt-in by the operator, and kube-apiserver and etcd operators (and potentially kcm and ks) have to consult the deployment topology in the infrastructure resource to decide. For more details see: openshift/enhancements#833 Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Lukasz Szaszkiewicz <lukasz.szaszkiewicz@gmail.com>
p0lyn0mial
force-pushed
the
startup-monitor
branch
from
f944c9a
to
7177173
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The main purpose of the new app is to provide a fallback mechanism that will make the operand to revert to the last healthy revision when the new revision fails.
The fallback mechanism is opt-in by the operator, and kube-apiserver and etcd operators (and potentially kcm and ks) have to consult the deployment topology in the infrastructure resource to decide.
Co-authored-by: Dr. Stefan Schimanski stefan.schimanski@gmail.com
Co-authored-by: Lukasz Szaszkiewicz lukasz.szaszkiewicz@gmail.com
For more details see: openshift/enhancements#833