Bug 1991357: installer_controller: only degraded if lastFailedRevision > currentRe…

[aojea]

…vision

Ccurrently the clusteroperator shows the component as degraded despite the last failing version is not the current version, and the operator was sucessfully installed.

Per example, it has degraded to True because something failed at revision 4

kube-apiserver             4.9.0-0.nightly-2021-08-07-175228   True        False         True       22m     NodeInstallerDegraded: 1 nodes are failing on revision 4:

However, the component is correct at revision 7

    reason: NodeInstaller_InstallerPodFailed
    status: "True"
    type: Degraded
  - lastTransitionTime: "2021-08-09T05:07:23Z"
    message: 'NodeInstallerProgressing: 3 nodes are at revision 7'
    reason: AsExpected
    status: "False"
    type: Progressing
  - lastTransitionTime: "2021-08-09T05:04:45Z"
    message: 'StaticPodsAvailable: 3 nodes are active; 3 nodes are at revision 7'
    reason: AsExpected
    status: "True"
    type: Available
  - lastTransitionTime: "2021-08-09T04:43:36Z"
    message: All is well
    reason: AsExpected
    status: "True"
    type: Upgradeable

Signed-off-by: Antonio Ojea aojea@redhat.com

[openshift-ci]

@aojea: This pull request references Bugzilla bug 1991357, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1991357: installer_controller: only degraded if lastFailedRevision > currentRe…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

/assign @sttts

[aojea]

/bugzilla refresh

[openshift-ci]

@aojea: This pull request references Bugzilla bug 1991357, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1991357: installer_controller: only degraded if lastFailedRevision > currentRe…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@aojea: An error was encountered querying GitHub for users with public email (kewang@redhat.com) for bug 1991357 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sttts]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/operator/OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfojtik]

/bugzilla refresh

[openshift-ci]

@mfojtik: This pull request references Bugzilla bug 1991357, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@aojea: All pull requests linked via external trackers have merged:

• openshift/library-go#1179

Bugzilla bug 1991357 has been moved to the MODIFIED state.

In response to this:

Bug 1991357: installer_controller: only degraded if lastFailedRevision > currentRe…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.