Bug 2084331: pkg/manifest/manifest.go: Fix checkResourceEnablement

[jottofar]

so a resource is filtered out if any of the capabilities are disabled.

[openshift-ci]

@jottofar: An error was encountered querying GitHub for users with public email (jiajliu@redhat.com) for bug 2084331 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

Post "http://ghproxy/graphql": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2084331: pkg/manifest/manifest.go: Fix checkResourceEnablement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/bugzilla refresh
/lgtm
/hold

Left a few comments inline, but nothing that I think needs to block merging. Ping me for a fresh LGTM if you decide to adjust anything, or pull the hold if you're fine as things stand.

[openshift-ci]

@wking: This pull request references Bugzilla bug 2084331, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
/lgtm
/hold

Left a few comments inline, but nothing that I think needs to block merging. Ping me for a fresh LGTM if you decide to adjust anything, or pull the hold if you're fine as things stand.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/bugzilla refresh

[openshift-ci]

@wking: This pull request references Bugzilla bug 2084331, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[LalatenduMohanty]

/lgtm

[LalatenduMohanty]

/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/manifest/OWNERS [LalatenduMohanty,jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jottofar]

/check-required-labels

[openshift-ci]

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@jottofar: All pull requests linked via external trackers have merged:

• openshift/library-go#1368

Bugzilla bug 2084331 has been moved to the MODIFIED state.

In response to this:

Bug 2084331: pkg/manifest/manifest.go: Fix checkResourceEnablement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.