Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-6254: bump(k8s): 1.26.1 #1442

Merged
merged 6 commits into from
Jan 20, 2023
Merged

OCPBUGS-6254: bump(k8s): 1.26.1 #1442

merged 6 commits into from
Jan 20, 2023

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Dec 13, 2022 •
edited

  • bump(k8s): use go1.19
  • bump(k8s): bump kube deps to 1.26.1
  • bump(k8s): react to SharedInformer interface changes
  • bump(k8s): update TestObserveFeatureFlags/techpreview test

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JoelSpeed JoelSpeed mentioned this pull request Jan 9, 2023
Merged
@odvarkadaniel odvarkadaniel mentioned this pull request Jan 9, 2023
Merged
@jluhrsen
Copy link

@sanchezl , I was working to do a rebase in CNO for k8s 1.26, but I think I will need to wait on this PR for lib-go.

If there is something I can do to help move this along, let me know and I'll find some cycles.

@sanchezl sanchezl force-pushed the bump-1.26 branch 2 times, most recently from 91c25a8 to efef631 Compare January 20, 2023 04:17
@sanchezl sanchezl changed the title bump(k8s): 1.26 bump(k8s): 1.26.1 Jan 20, 2023
@sanchezl sanchezl marked this pull request as ready for review January 20, 2023 04:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@sanchezl sanchezl mentioned this pull request Jan 20, 2023
Merged
@sanchezl
Copy link
Contributor Author

/hold for:

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2023
This was referenced Jan 20, 2023
Merged
Merged
Merged
@sanchezl sanchezl mentioned this pull request Jan 20, 2023
Merged
@sanchezl sanchezl changed the title bump(k8s): 1.26.1 OCPBUGS-6254: bump(k8s): 1.26.1 Jan 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 20, 2023
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Jira Issue OCPBUGS-6254, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • bump(k8s): use go1.19
  • bump(k8s): bump kube deps to 1.26.1
  • bump(k8s): react to SharedInformer interface changes
  • bump(k8s): update TestObserveFeatureFlags/techpreview test
  • proof: use api/client-go with 1.26 bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 20, 2023
@sanchezl
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot requested a review from wangke19 January 20, 2023 20:41
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Jira Issue OCPBUGS-6254, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

  • bump(k8s): use go1.19
  • bump(k8s): bump kube deps to 1.26.1
  • bump(k8s): react to SharedInformer interface changes
  • bump(k8s): update TestObserveFeatureFlags/techpreview test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2023
@sanchezl
Copy link
Contributor Author

/test unit

1 similar comment
@soltysh
Copy link
Member

soltysh commented Jan 20, 2023

/test unit

soltysh
soltysh approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9bc3058 into openshift:master Jan 20, 2023
@openshift-ci-robot
Copy link

@sanchezl: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6254 has been moved to the MODIFIED state.

In response to this:

  • bump(k8s): use go1.19
  • bump(k8s): bump kube deps to 1.26.1
  • bump(k8s): react to SharedInformer interface changes
  • bump(k8s): update TestObserveFeatureFlags/techpreview test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@deads2k deads2k Awaiting requested review from deads2k

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanchezl @jluhrsen @openshift-ci-robot @soltysh @openshift-merge-robot