API-1509: Enable aes-gcm encryption provider #1469
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
|
The e2e-aws-encryption seem to have been broken for a while: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_library-go/1469/pull-ci-openshift-library-go-master-e2e-aws-encryption/1626266910360342528/artifacts/e2e-aws-encryption/test/build-log.txt. Although the job succeeds, it doesn't do anything at the moment. |
dgrisonnet
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dgrisonnet
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@dgrisonnet: This pull request references API-1509 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -9,6 +9,7 @@ import ( | |||
| var ( | |||
| ModeToNewKeyFunc = map[state.Mode]func() []byte{ | |||
| state.AESCBC: NewAES256Key, | |||
| state.AESGCM: NewAES256Key, | |||
There was a problem hiding this comment.
I didn't realize it was exactly the same key. That's convenient.
|
@deads2k can you please have another look at this PR now that the API has been merged? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, dinhxuanvu, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dgrisonnet: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
proof PR: openshift/cluster-kube-apiserver-operator#1446