-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPCLOUD-1988] Migrate AWS to out of tree cloud provider #1485
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CI results looks good (linked in description) though with some flakes, I think this should be good to go. Will monitor CI results for AWS over the next few days to check stability. |
as in prior runs, a payload containing all the changes will bootstrap and upgrade successfully. The manual verification across PRs is green. I'm button merging these to ensure we don't get a payload that is missing some of the changes. |
* Remove aws tech-preview jobs for CCM related repos AWS cloud-controller-manager got to GA and installs by default now. xref: - openshift/library-go#1485 * Remove aws tech-preview jobs for CCM related repos for 4.14 release AWS cloud-controller-manager got to GA and installs by default now. xref: - openshift/library-go#1485
* Remove aws tech-preview jobs for CCM related repos AWS cloud-controller-manager got to GA and installs by default now. xref: - openshift/library-go#1485 * Remove aws tech-preview jobs for CCM related repos for 4.14 release AWS cloud-controller-manager got to GA and installs by default now. xref: - openshift/library-go#1485
This PR migrates the AWS cloud provider from in-tree to out-of-tree. It must be merged in tandem with the PR for KCMO and CCMO to avoid a build that contains one or the other operator PRs without the other. If either merges without the other, it will either lead to no cloud controllers or duplicate cloud controllers, either of which will not work well.
Note the AWS cloud provider code has been removed from K8s in-tree in 1.27, this must merge in 4.14.