Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1263: Bump k8s 1.27 #1488

Merged
merged 6 commits into from May 3, 2023
Merged

STOR-1263: Bump k8s 1.27 #1488

merged 6 commits into from May 3, 2023

Conversation

bertinatto
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2023 •
edited by openshift-ci bot

@bertinatto: This pull request references STOR-1263 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bertinatto bertinatto marked this pull request as ready for review March 20, 2023 17:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@bertinatto bertinatto changed the title STOR-1263: Bump k8s 1.27 WIP: STOR-1263: Bump k8s 1.27 Mar 20, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@openshift-ci openshift-ci bot requested review from deads2k and dmage March 20, 2023 17:25
@bertinatto bertinatto force-pushed the bump-k8s-1.27 branch 8 times, most recently from d657e63 to da396dd Compare March 21, 2023 17:37
@bertinatto
Copy link
Member Author

/test unit

@bertinatto
Copy link
Member Author

/test e2e-aws-encryption

@bertinatto bertinatto force-pushed the bump-k8s-1.27 branch 2 times, most recently from b54d2fb to cd81cd5 Compare March 25, 2023 13:52
soltysh
soltysh approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold to not accidentally merge this 😅 due to fake lib bumps
one nit is to squash the bumps together

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@bertinatto bertinatto changed the title WIP: STOR-1263: Bump k8s 1.27 STOR-1263: Bump k8s 1.27 Apr 28, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2023
@bertinatto
Copy link
Member Author

/test unit

bertinatto
bertinatto commented May 3, 2023
View reviewed changes
go.mod
@@ -16,32 +16,32 @@ require (
github.com/imdario/mergo v0.3.7
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
github.com/opencontainers/go-digest v1.0.0-rc1
github.com/openshift/api v0.0.0-20230426193520-54a14470e5dc
github.com/openshift/api v0.0.0-20230503133300-8bbcb7ca7183
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct sha: https://github.com/openshift/api/commits/master

bertinatto
bertinatto commented May 3, 2023
View reviewed changes
go.mod
github.com/openshift/build-machinery-go v0.0.0-20220913142420-e25cf57ea46d
github.com/openshift/client-go v0.0.0-20230120202327-72f107311084
github.com/openshift/client-go v0.0.0-20230503144108-75015d2347cb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also correct sha: https://github.com/openshift/client-go/commits/master

@deads2k
Copy link
Contributor

deads2k commented May 3, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

/test e2e-aws-encryption
clusteroperator/etcd is progressing: NodeInstallerProgressing: 1 nodes are at revision 6; 2 nodes are at revision 7

@bertinatto
Copy link
Member Author

The test seems to be failing for unrelated reasons:

{  "e2e-aws-encryption" pod "e2e-aws-encryption-gather-extra" failed: could not watch pod: the pod ci-op-swc38zxm/e2e-aws-encryption-gather-extra failed after 44s (failed containers: test): ContainerFailed one or more containers exited

The encryption test seem to be OK:

 INFO[2023-05-03T16:20:52Z] Running step e2e-aws-encryption-test.        
INFO[2023-05-03T16:21:46Z] Step e2e-aws-encryption-test succeeded after 54s.

/test e2e-aws-encryption

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 95ca3c1 into openshift:master May 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@dmage dmage Awaiting requested review from dmage

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bertinatto @openshift-ci-robot @deads2k @soltysh @openshift-merge-robot