[OCPCLOUD-2034] Update Cloud Provider code to use new Azure/GCP specific feature gates #1505
Conversation
JoelSpeed
force-pushed
the
ccm-individual-gates
branch
from
d0f6bb7
to
298bbe0
Compare
JoelSpeed
force-pushed
the
ccm-individual-gates
branch
from
298bbe0
to
a4339a3
Compare
JoelSpeed
changed the title
| } | ||
| } | ||
|
|
||
| // If any of the desired feature gates are enabled, then the external cloud provider should be used. |
There was a problem hiding this comment.
if we end up stuck here a while, I think specific desire trumps non-specific desire.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test unit I think the tests timed out |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR teaches the ExternalCloudProvider decision to understand new Azure and GCP feature gates so that these two CCMs can be promoted individually.
CC @deads2k