Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-1890: Bump k8s api to v0.29.0 #1627

Merged
merged 1 commit into from Dec 18, 2023
Merged

OCPNODE-1890: Bump k8s api to v0.29.0 #1627

merged 1 commit into from Dec 18, 2023

Conversation

sairameshv
Copy link
Member

cc: @soltysh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2023 •
edited by openshift-ci bot

@sairameshv: This pull request references OCPNODE-1890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

cc: @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sairameshv sairameshv force-pushed the rebase-1.29 branch 3 times, most recently from 24cf430 to 574ad35 Compare November 27, 2023 08:36
soltysh
soltysh requested changes Nov 28, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@sairameshv sairameshv force-pushed the rebase-1.29 branch 2 times, most recently from 5559720 to 61dc49f Compare November 29, 2023 06:43
@sairameshv sairameshv changed the title OCPNODE-1890: Bump k8s api to v0.29.0-alpha.3 OCPNODE-1890: Bump k8s api to v0.29.0-rc.1 Nov 29, 2023
@sairameshv sairameshv marked this pull request as ready for review November 29, 2023 06:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@sairameshv sairameshv force-pushed the rebase-1.29 branch 2 times, most recently from 74c01d9 to 3fe382d Compare November 30, 2023 10:24
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2023
@sairameshv sairameshv force-pushed the rebase-1.29 branch 2 times, most recently from 964fa81 to 23716e2 Compare December 6, 2023 14:12
@sairameshv sairameshv changed the title OCPNODE-1890: Bump k8s api to v0.29.0-rc.1 OCPNODE-1890: Bump k8s api to v0.29.0 Dec 18, 2023
@sairameshv
Bump k8s api to v0.29.0
ef92885 
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
soltysh
soltysh approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 99cedb2 into openshift:master Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sairameshv @openshift-ci-robot @soltysh @openshift-merge-robot