AUTH-442: add ClusterFleetEvaluation type to status controller #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
|
@ibihim: This pull request references AUTH-442 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dgrisonnet
reviewed
Nov 29, 2023
| configv1helpers.SetStatusCondition(&clusterOperatorObj.Status.Conditions, UnionClusterCondition("Progressing", operatorv1.ConditionFalse, nil, currentDetailedStatus.Conditions...)) | ||
| configv1helpers.SetStatusCondition(&clusterOperatorObj.Status.Conditions, UnionClusterCondition("Available", operatorv1.ConditionTrue, nil, currentDetailedStatus.Conditions...)) | ||
| configv1helpers.SetStatusCondition(&clusterOperatorObj.Status.Conditions, UnionClusterCondition("Upgradeable", operatorv1.ConditionTrue, nil, currentDetailedStatus.Conditions...)) | ||
| configv1helpers.SetStatusCondition(&clusterOperatorObj.Status.Conditions, UnionClusterCondition(string(configv1.OperatorDegraded), operatorv1.ConditionFalse, c.degradedInertia, currentDetailedStatus.Conditions...)) |
There was a problem hiding this comment.
Instead of casting everytime, we could change the signature of the UnionClusterCondition function and cast there. We should only change the signature of the cluster one because the cluster operator condition is typed (https://github.com/openshift/api/blob/a782d1c1541ca8ae0fd17fff5f1dc8a8990dc195/config/v1/types_cluster_operator.go#L122) which is the not the case of the operator condition: https://github.com/openshift/api/blob/master/operator/v1/types.go#L165
(no clue why that is the case 🤷♂️)
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
ibihim
force-pushed
the
AUTH-442_psa_cluster-fleet-evaluation_add-evalution-condition
branch
2 times, most recently
from
5c241e1
to
1176113
Compare
ibihim
force-pushed
the
AUTH-442_psa_cluster-fleet-evaluation_add-evalution-condition
branch
from
1176113
to
05fdbe4
Compare
ibihim
force-pushed
the
AUTH-442_psa_cluster-fleet-evaluation_add-evalution-condition
branch
from
05fdbe4
to
17f9e42
Compare
|
@ibihim: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, ibihim, mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ibihim
deleted the
AUTH-442_psa_cluster-fleet-evaluation_add-evalution-condition
branch
|
/cherry-pick release-4.14 |
|
@ibihim: #1634 failed to apply on top of branch "release-4.14": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add ClusterFleetEvaluationType to status controller.
Why
It is a valid ClusterOperator status, but doesn't have a mechanism to be pulled from Operator's status into ClusterOperator's status.