OCPCLOUD-2514: Cloud Provider External no longer depends on a feature gate

[JoelSpeed]

The final external cloud providers were promoted in 4.15. Feature gates are no longer required to make the decision on whether the CCMs should be GA or not. This PR removes the feature gate access and cleans up the function so that it may continue to provide a respect of which platforms are external going forward, without the need for feature gate access.

Once this is merged, KASO, KCMO, MCO and CCMO will all need to be updated.

[openshift-ci-robot]

@JoelSpeed: This pull request references OCPCLOUD-2514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

The final external cloud providers were promoted in 4.15. Feature gates are no longer required to make the decision on whether the CCMs should be GA or not. This PR removes the feature gate access and cleans up the function so that it may continue to provide a respect of which platforms are external going forward, without the need for feature gate access.

Once this is merged, KASO, KCMO, MCO and CCMO will all need to be updated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[soltysh]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/OWNERS [JoelSpeed,soltysh]
• pkg/operator/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment