Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moves encryption controllers to apiservercontrollerset #756

Merged
merged 1 commit into from
Mar 27, 2020
Merged

moves encryption controllers to apiservercontrollerset #756

merged 1 commit into from
Mar 27, 2020

Conversation

p0lyn0mial
Copy link
Contributor

No description provided.

@p0lyn0mial
Copy link
Contributor Author

/hold

haven't tested

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Mar 25, 2020 •
edited

this pull deprecates and builds on #676

@p0lyn0mial
Copy link
Contributor Author

to test it in openshift-apiserver I need openshift/cluster-openshift-apiserver-operator#345 first

@p0lyn0mial
Copy link
Contributor Author

/assign @stlaz @sttts

@p0lyn0mial p0lyn0mial force-pushed the encryption-controllers-to-api-server-cs branch from b7a5253 to 7d00f12 Compare March 27, 2020 11:51
@p0lyn0mial
Copy link
Contributor Author

/hold cancel

it works openshift/cluster-openshift-apiserver-operator#346

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2020
@p0lyn0mial p0lyn0mial force-pushed the encryption-controllers-to-api-server-cs branch from 7d00f12 to 3a0b429 Compare March 27, 2020 12:00
@stlaz
Copy link
Member

stlaz commented Mar 27, 2020

/lgtm
great to see it work \o/

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@sttts
Copy link
Contributor

sttts commented Mar 27, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 163b2f0 into openshift:master Mar 27, 2020
@p0lyn0mial p0lyn0mial mentioned this pull request Mar 27, 2020
Closed
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
@openshift-merge-robot
Merge pull request openshift#756 from p0lyn0mial/encryption-controlle…
cf4febc 
…rs-to-api-server-cs

moves encryption controllers to apiservercontrollerset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@stlaz stlaz

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @stlaz @sttts @openshift-ci-robot @openshift-merge-robot