Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-292] - Update RHPAM and RHMD templates and imagestreams on … #184

Merged
merged 1 commit into from
Aug 15, 2019
Merged

[KIECLOUD-292] - Update RHPAM and RHMD templates and imagestreams on … #184

merged 1 commit into from
Aug 15, 2019

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Aug 14, 2019

…OpenShift Service Catalog for release 7.4.1

Signed-off-by: Filippe Spolti fspolti@redhat.com

@openshift-ci-robot
Copy link

Hi @spolti. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2019
@gabemontero
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2019
@gabemontero
Copy link
Contributor

/approve

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2019
@gabemontero
Copy link
Contributor

the verify tests says that make import needs to be run: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_library/184/pull-ci-openshift-library-master-verify/15#0:build-log.txt%3A5886

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@spolti
Copy link
Contributor Author

spolti commented Aug 14, 2019 •
edited

I executed import_content script, shouldn't have the same result?

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 14, 2019
@spolti
Copy link
Contributor Author

spolti commented Aug 15, 2019

Hi, can this PR be merged?

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@spolti
Copy link
Contributor Author

spolti commented Aug 15, 2019

looks like the SSO guys are actively updating the templates, yesterday this same test has passed.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2019
@spolti
Copy link
Contributor Author

spolti commented Aug 15, 2019

/retest

@spolti
Copy link
Contributor Author

spolti commented Aug 15, 2019 •
edited

@gabemontero can you please help to understand what is happening in this case?
The test reported changes, but I just run make import and verify and no problems were reported:

Diffing current official directory against freshly generated official directory SUCCESS: Generated official directory up to date. Diffing current community directory against freshly generated community directory SUCCESS: Generated community directory up to date. ✔ /data/dev/sources/library [KIECLOUD-292 L|…5]

@coreydaley
Copy link
Member

@spolti You need to commit the results of whatever changes make import pulls in. Can you try running git status or git diff and see if there are any changes that need to be committed?

@coreydaley
Copy link
Member

Side Note: Interesting that the Travis make verify succeeded...

@spolti
Copy link
Contributor Author

spolti commented Aug 15, 2019

@coreydaley I did this, but now I am trying different, reset my branch to head, rebase and re-import, let's see how it goes now.

@spolti
[KIECLOUD-292] - Update RHPAM and RHMD templates and imagestreams on …
3cd7b2d 
…OpenShift Service Catalog for release 7.4.1

Signed-off-by: Filippe Spolti <fspolti@redhat.com>
@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ca308c1 into openshift:master Aug 15, 2019
@spolti spolti deleted the KIECLOUD-292 branch August 15, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spolti @openshift-ci-robot @gabemontero @openshift-bot @coreydaley @openshift-merge-robot