Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null pointer when updating clockClass #190

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jzding
Copy link
Contributor

@jzding jzding commented Aug 15, 2023

No description provided.

Copy link
Contributor

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@jzding
Copy link
Contributor Author

jzding commented Aug 15, 2023

/override ci/prow/e2e-aws
/override ci/prow/images

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@jzding
Copy link
Contributor Author

jzding commented Aug 15, 2023

/override ci/prow/images
/override ci/prow/e2e-aws

Signed-off-by: Jack Ding <jackding@gmail.com>
@vitus133
Copy link
Contributor

/lgtm

@vitus133
Copy link
Contributor

/override ci/prow/images
/override ci/prow/e2e-aws

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@jzding: jzding unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vitus133
Copy link
Contributor

/lgtm

@vitus133
Copy link
Contributor

/override ci/prow/images
/override ci/prow/e2e-aws

@vitus133
Copy link
Contributor

/override ci/prow/images
/override ci/prow/e2e-aws
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@jzding: jzding unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override ci/prow/images
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

In response to this:

/override ci/prow/images
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

In response to this:

/override ci/prow/images
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

In response to this:

/override ci/prow/images
/override ci/prow/e2e-aws
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@jzding: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8bca749 into openshift:master Aug 15, 2023
4 checks passed
@jzding jzding deleted the fix-clock-class branch August 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants