Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18270: Add readme for e810 plugin #203

Merged
merged 1 commit into from
Sep 14, 2023
Merged

OCPBUGS-18270: Add readme for e810 plugin #203

merged 1 commit into from
Sep 14, 2023

Conversation

josephdrichard
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@josephdrichard josephdrichard changed the title Add readme for e810 plugin OCPBUGS-18270: Add readme for e810 plugin Aug 29, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 29, 2023
@openshift-ci-robot
Copy link
Contributor

@josephdrichard: This pull request references Jira Issue OCPBUGS-18270, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 29, 2023
aneeshkp
aneeshkp reviewed Aug 29, 2023
View reviewed changes
addons/intel/README.md Outdated Show resolved Hide resolved
aneeshkp
aneeshkp reviewed Aug 29, 2023
View reviewed changes
addons/intel/README.md
......
plugins:
e810:
enableDefaultConfig: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this as by default false? at this point this is usable only for non WPC or if you want to use ts2phc only , correct ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already by default is false

@hongkailiu
Copy link
Member

/test images

@aneeshkp
Copy link
Contributor

aneeshkp commented Sep 7, 2023

do we have plugin setting for localMaxOffset and LocalHoldOver values ?

@josephdrichard
Copy link
Contributor Author

do we have plugin setting for localMaxOffset and LocalHoldOver values ?

updated

@aneeshkp
Copy link
Contributor

/lgtm

@aneeshkp
Copy link
Contributor

/test e2e-aws

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aneeshkp,josephdrichard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josephdrichard
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 14, 2023
@openshift-ci-robot
Copy link
Contributor

@josephdrichard: This pull request references Jira Issue OCPBUGS-18270, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

@josephdrichard: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a5c513f into openshift:master Sep 14, 2023
5 checks passed
@openshift-ci-robot
Copy link
Contributor

@josephdrichard: Jira Issue OCPBUGS-18270: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18270 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 14, 2023
Merged
@openshift-cherrypick-robot
Copy link

@aneeshkp: new pull request created: #211

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hhassid
Copy link

hhassid commented Sep 14, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshkp aneeshkp aneeshkp left review comments

@pliurh pliurh Awaiting requested review from pliurh

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees

@aneeshkp aneeshkp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@josephdrichard @openshift-ci-robot @hongkailiu @aneeshkp @openshift-cherrypick-robot @hhassid @openshift-merge-robot