Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20183: PTP4L output in T-GM #224

Merged
merged 1 commit into from
Oct 12, 2023
Merged

OCPBUGS-20183: PTP4L output in T-GM #224

merged 1 commit into from
Oct 12, 2023

Conversation

aneeshkp
Copy link
Contributor

set time property to true for clock class 6 and 7

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 10, 2023
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: This pull request references Jira Issue OCPBUGS-20183, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

set time property to true for clock class 6 and 7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from fepan and s1061123 October 10, 2023 16:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
jnunyez
jnunyez reviewed Oct 10, 2023
View reviewed changes
pkg/event/event_test.go
@@ -35,8 +35,8 @@ func monkeyPatch() {
CurrentUtcOffsetValid: false,
Copy link

@jnunyez jnunyez Oct 10, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the equivalent to UTC_REASONABLE? Should be set to true when clockClass announced is 6 and UTCOffset is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set CurrentUtcOffsetValid to true for 6 and 7

jnunyez
jnunyez reviewed Oct 10, 2023
View reviewed changes
pkg/event/event_test.go
TimeTraceable: false,
FrequencyTraceable: false,
TimeTraceable: true,
FrequencyTraceable: true,
PtpTimescale: false,
TimeSource: 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the equivalent to TimeSource in ptp4l packets? Should 0x20 (GPS) for T-GM when GNSS connected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to GNSS when connected . and set to unknown when GNSS is lost

@aneeshkp aneeshkp force-pushed the time-source branch 2 times, most recently from ccb1683 to 3d92cb0 Compare October 10, 2023 18:36
@aneeshkp
set timeproperty to true for clock class 6 and 7
9064e48 
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
@aneeshkp
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2023
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: This pull request references Jira Issue OCPBUGS-20183, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gsr-shanks

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Contributor Author

/regression_complete

@aneeshkp
Copy link
Contributor Author

/cc @jzding

@openshift-ci openshift-ci bot requested a review from jzding October 12, 2023 13:43
jzding
jzding approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 5c7c59f into openshift:master Oct 12, 2023
5 checks passed
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: Jira Issue OCPBUGS-20183: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20183 has been moved to the MODIFIED state.

In response to this:

set time property to true for clock class 6 and 7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@aneeshkp: new pull request created: #229

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnunyez jnunyez jnunyez left review comments

@jzding jzding jzding approved these changes

@fepan fepan Awaiting requested review from fepan

@s1061123 s1061123 Awaiting requested review from s1061123

@gsr-shanks gsr-shanks Awaiting requested review from gsr-shanks

Assignees

@jzding jzding

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aneeshkp @openshift-ci-robot @openshift-cherrypick-robot @jzding @jnunyez