Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-24043: nmea_status and clock_class metrics missing in 4.14 linuxptpdaemon #242

Merged
merged 1 commit into from
Nov 29, 2023
Merged

OCPBUGS-24043: nmea_status and clock_class metrics missing in 4.14 linuxptpdaemon #242

merged 1 commit into from
Nov 29, 2023

Conversation

aneeshkp
Copy link
Contributor

add clock class metrics

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: This pull request references Jira Issue OCPBUGS-24043, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

add clock class metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@jzding
Copy link
Contributor

jzding commented Nov 28, 2023

/retest-required

1 similar comment
@aneeshkp
Copy link
Contributor Author

/retest-required

jzding
jzding reviewed Nov 29, 2023
View reviewed changes
pkg/daemon/metrics.go Outdated
Namespace: PTPNamespace,
Subsystem: PTPSubsystem,
Name: "clock_class",
Help: "6 = Locked,7 = PRC unlocked but still in spec,52, 187 = PRC unlocked and out of spec,248 = Default,255 = Slave Only Clock",
Copy link
Contributor

@jzding jzding Nov 29, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"6 = Locked, 7 = PRC unlocked in-spec, 52/187 = PRC unlocked out-of-spec, 248 = Default, 255 = Slave Only Clock"

jzding
jzding reviewed Nov 29, 2023
View reviewed changes
pkg/daemon/metrics.go Outdated
Subsystem: PTPSubsystem,
Name: "clock_class",
Help: "6 = Locked,7 = PRC unlocked but still in spec,52, 187 = PRC unlocked and out of spec,248 = Default,255 = Slave Only Clock",
}, []string{"node"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in cloud-event-proxy this is defined as []string{"process", "node"}

jzding
jzding reviewed Nov 29, 2023
View reviewed changes
pkg/daemon/metrics.go Outdated
// UpdateClockClassMetrics ... update clock class metrics
func UpdateClockClassMetrics(clockClass float64) {
ClockClassMetrics.With(prometheus.Labels{
"node": NodeName}).Set(float64(clockClass))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add process

@jzding
Copy link
Contributor

jzding commented Nov 29, 2023

/retest-required

@aneeshkp aneeshkp force-pushed the add-clock-class-metrics branch 2 times, most recently from 372e7df to 30aded7 Compare November 29, 2023 16:02
jzding
jzding approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@aneeshkp
add clock class metrics
8097dc3 
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
jzding
jzding approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aneeshkp aneeshkp changed the title OCPBUGS-24043: nmea_status and clock_state metrics missing in 4.14 linuxptpdaemonadd clock class metrics OCPBUGS-24043: nmea_status and clock_class metrics missing in 4.14 linuxptpdaemonadd clock class metrics Nov 29, 2023
@aneeshkp aneeshkp changed the title OCPBUGS-24043: nmea_status and clock_class metrics missing in 4.14 linuxptpdaemonadd clock class metrics OCPBUGS-24043: nmea_status and clock_class metrics missing in 4.14 linuxptpdaemon Nov 29, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dd7b86c into openshift:master Nov 29, 2023
5 checks passed
@openshift-ci-robot
Copy link
Contributor

@aneeshkp: Jira Issue OCPBUGS-24043: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24043 has been moved to the MODIFIED state.

In response to this:

add clock class metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-linuxptp-daemon-container-v4.15.0-202311292108.p0.gdd7b86c.assembly.stream for distgit linuxptp-daemon.
All builds following this will include this PR.

@jzding jzding mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzding jzding jzding approved these changes

@nishant-parekh nishant-parekh Awaiting requested review from nishant-parekh

@vitus133 vitus133 Awaiting requested review from vitus133

Assignees

@jzding jzding

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aneeshkp @openshift-ci-robot @jzding @openshift-bot