Bug OCPBUGS-24304: GM clock state stays locked when 1PPS lost #244
Conversation
jzding
force-pushed
the
demo-fix
branch
2 times, most recently
from
1d4ac79
to
5834c13
Compare
openshift-ci-robot
added
jira/valid-reference
|
@jzding: This pull request references Jira Issue OCPBUGS-24304, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jzding
changed the title
jzding
force-pushed
the
demo-fix
branch
3 times, most recently
from
518c2d4
to
ba5e752
Compare
Fixed the following issues: When an event is received with an iface not found in the stored in-memory data, the whole Data is re-created before adding DataDetails for this event and DataDetails for other ifaces are wiped out. As a result, there is only one iface event data is stored in-memory at any given time and the GM State calculation is only based on this one iface instead of multiple ifaces. Another issue is the event data for dpll is stored using iface alias, while event data for gnss is stored using iface name, resulting same interface having multiple entries in in-memory data. Signed-off-by: Jack Ding <jackding@gmail.com>
|
@jzding: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, jzding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jzding: Jira Issue OCPBUGS-24304: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24304 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-linuxptp-daemon-container-v4.15.0-202312041611.p0.g9bba8cb.assembly.stream for distgit linuxptp-daemon. |
Fixed the following issues:
When an event is received with an iface not found in the stored in-memory data, the whole Data is re-created before adding DataDetails for this event and DataDetails for other ifaces are wiped out. As a result, there is only one iface event data is stored in-memory at any given time and the GM State calculation is only based on this one iface instead of multiple ifaces.
Another issue is the event data for dpll is stored using iface alias, while event data for gnss is stored using iface name, resulting same interface having multiple entries in in-memory data.