Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-30982: add DPLL phase offset #284

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

[release-4.14] OCPBUGS-30982: add DPLL phase offset #284

wants to merge 1 commit into from

Conversation

vitus133
Copy link
Contributor

This is a manual cherry-pick from three commits: #271, #276 and #279.
Add DPLL pin notification parser and handle pin notifications. Distinguish between pin notifications and device notifications. Update DPLL phase offset if included for the pin belonging to the DPLL instance.
/cc @aneeshkp @jzding @josephdrichard @nishant-parekh

OCPBUGS-30982: add DPLL phase offset
150655b 
Add DPLL pin notification parser and handle pin notifications.
Distinguish between pin notifications and device notifications.
Update DPLL phase offset if included for the pin belonging to the
DPLL instance.

Signed-off-by: Vitaly Grinberg <v.g@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 17, 2024
@openshift-ci-robot
Copy link
Contributor

@vitus133: This pull request references Jira Issue OCPBUGS-30982, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30810 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick from three commits: #271, #276 and #279.
Add DPLL pin notification parser and handle pin notifications. Distinguish between pin notifications and device notifications. Update DPLL phase offset if included for the pin belonging to the DPLL instance.
/cc @aneeshkp @jzding @josephdrichard @nishant-parekh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 17, 2024

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vitus133
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vitus133: This pull request references Jira Issue OCPBUGS-30982, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30810 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vitus133
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 10, 2024
@openshift-ci-robot
Copy link
Contributor

@vitus133: This pull request references Jira Issue OCPBUGS-30982, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-30810 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30810 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 10, 2024
@aneeshkp
Copy link
Contributor

/title [release-4.14] OCPBUGS-30982: add DPLL phase offset

@aneeshkp
Copy link
Contributor

on hold until we have the bug fix merged to 4.15

@aneeshkp
Copy link
Contributor

/retitle [release-4.14] OCPBUGS-30982: add DPLL phase offset

@openshift-ci openshift-ci bot changed the title OCPBUGS-30982: add DPLL phase offset [release-4.14] OCPBUGS-30982: add DPLL phase offset Apr 12, 2024
jzding
jzding approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jzding
Copy link
Contributor

jzding commented Apr 18, 2024

/label backport-risk-assessed

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 18, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aneeshkp aneeshkp mentioned this pull request Apr 18, 2024
Merged
@aneeshkp
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@aneeshkp
Copy link
Contributor

@vitus133 Can you please close this PR. I have consolidated all PR to #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzding jzding jzding approved these changes

@aneeshkp aneeshkp Awaiting requested review from aneeshkp

@josephdrichard josephdrichard Awaiting requested review from josephdrichard

@nishant-parekh nishant-parekh Awaiting requested review from nishant-parekh

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@gsr-shanks gsr-shanks

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet