OCPBUGS-31422: PTP container logs lack severity information #286
Conversation
openshift-ci
bot
added
the
approved
aneeshkp
force-pushed
the
fix-log-severity
branch
3 times, most recently
from
2ba1596
to
f3d2901
Compare
aneeshkp
changed the title
openshift-ci-robot
added
jira/severity-important
|
@aneeshkp: This pull request references Jira Issue OCPBUGS-31422, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@aneeshkp: This pull request references Jira Issue OCPBUGS-31422, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@aneeshkp: This pull request references Jira Issue OCPBUGS-31422, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pkg/daemon/daemon.go
Outdated
| @@ -451,7 +453,7 @@ func (dn *Daemon) applyNodePtpProfile(runID int, nodeProfile *ptpv1.PtpProfile) | |||
| socketPath = fmt.Sprintf("/var/run/ptp4l.%d.socket", runID) | |||
| configFile = fmt.Sprintf("ts2phc.%d.config", runID) | |||
| configPath = fmt.Sprintf("/var/run/%s", configFile) | |||
| messageTag = fmt.Sprintf("[ts2phc.%d.config]", runID) | |||
| messageTag = fmt.Sprintf("[ts2phc.%d.config]:{level}", runID) | |||
There was a problem hiding this comment.
[ts2phc.%d.config:{level}]
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
aneeshkp
force-pushed
the
fix-log-severity
branch
from
f3d2901
to
a1db2c5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, josephdrichard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aneeshkp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@aneeshkp: Jira Issue OCPBUGS-31422: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31422 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-linuxptp-daemon-container-v4.16.0-202403261946.p0.g00bc142.assembly.stream.el9 for distgit linuxptp-daemon. |
Enable log severity via message_tag the log severity will be suffixed to message tag and available in container logs
example : ptp4l[2464681.628]: [ptp4l.1.config:7] master offset -4 s2 freq -26835 path delay 525
ptp4l[2485169.871]: [ptp4l.0.config:3] increasing tx_timestamp_timeout or increasing kworker priority may correct this issue, but a driver bug likely causes it
ptp4l[2485169.871]: [ptp4l.0.config:3] port 1 (ens2f0): send delay request failed
ptp4l[2485169.871]: [ptp4l.0.config:5] port 1 (ens2f0): SLAVE to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)
ptp4l[2485169.880]: [ptp4l.1.config:6] master offset -1 s2 freq -26803 path
3=Error ;5=Warning 6=Debug