Bug 1781502: Updating LSO to use digest for 4.3 #100

huffmanca · 2020-03-27T19:50:14Z

We currently use digests for 4.4 and 4.5; however, because we specify the versions instead of relying on the olm.skipRange to subscribe to the correct channel. Changing this to be latest should allow ART to correctly use the digest instead of the tag.

openshift-ci-robot · 2020-03-27T19:50:15Z

@huffmanca: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating LSO to use digest for 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-27T19:50:53Z

@huffmanca: This pull request references Bugzilla bug 1781502, which is invalid:

expected Bugzilla bug 1781502 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1781502: Updating LSO to use digest for 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

huffmanca · 2020-03-27T20:43:18Z

/retest

jsafrane · 2020-03-30T09:55:48Z

/retest

gnufied · 2020-03-30T12:51:38Z

manifests/4.2/local-storage-operator.v4.2.0.clusterserviceversion.yaml

    support: Red Hat
    repository: https://github.com/openshift/local-storage-operator
    createdAt: "2019-08-14T00:00:00Z"
    description: Configure and use local storage volumes in kubernetes and Openshift
+    olm.skipRange: '>=4.2.0 <4.3.0'


A 4.2 manifest in 4.3 branch should have no effect IMO on build process. It is only kept for keeping build scripts happy when transition between branches happen.

Understood. I can remove this reference here.

gnufied · 2020-03-30T12:53:44Z

manifests/4.3/local-storage-operator.v4.3.0.clusterserviceversion.yaml

@@ -29,7 +29,7 @@ metadata:
      ]
    categories: Storage
    capabilities: Full Lifecycle
-    containerImage: quay.io/openshift/origin-local-storage-operator:4.3.0
+    containerImage: quay.io/openshift/origin-local-storage-operator:latest


I thought this is only for display purpose in the UI. The actual image version is mentioned below which does get replaced by the ART pipeline.

This is still a good idea to do but this may not fix the bug that was reported.

We discussed this on slack. I'm reaching out to the reporter of the issue to confirm that the images are still correct, and that it's simply the containerImage reporting the tag instead of the digest.

I'm leaving this as is for now, as the reported issue involves fetching the containerImage and it reporting an incorrect tag.

gnufied · 2020-04-02T15:08:32Z

/lgtm

huffmanca · 2020-04-03T14:36:05Z

/bugzilla refresh

openshift-ci-robot · 2020-04-03T14:36:08Z

@huffmanca: This pull request references Bugzilla bug 1781502, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnufied · 2020-04-03T14:37:37Z

make it depend on https://bugzilla.redhat.com/show_bug.cgi?id=1770183 BZ? @huffmanca

huffmanca · 2020-04-03T14:43:17Z

/bugzilla refresh

openshift-ci-robot · 2020-04-03T14:43:20Z

@huffmanca: This pull request references Bugzilla bug 1781502, which is invalid:

expected dependent Bugzilla bug 1770183 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

huffmanca · 2020-04-03T14:43:48Z

/bugzilla refresh

openshift-ci-robot · 2020-04-03T14:43:54Z

@huffmanca: This pull request references Bugzilla bug 1781502, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1817826 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1817826 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knobunc · 2020-04-03T19:48:26Z

/approve

openshift-ci-robot · 2020-04-03T19:48:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, huffmanca, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eparis · 2020-04-16T03:30:14Z

/bugzilla refresh

openshift-ci-robot · 2020-04-16T03:30:17Z

@eparis: This pull request references Bugzilla bug 1781502, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1817826 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1817826 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

huffmanca · 2020-04-16T13:40:19Z

/retest

openshift-ci-robot · 2020-04-16T14:35:25Z

@huffmanca: All pull requests linked via external trackers have merged: openshift/local-storage-operator#100. Bugzilla bug 1781502 has been moved to the MODIFIED state.

In response to this:

Bug 1781502: Updating LSO to use digest for 4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from gnufied and tsmetana March 27, 2020 19:50

huffmanca changed the title ~~Updating LSO to use digest for 4.3~~ Bug 1781502: Updating LSO to use digest for 4.3 Mar 27, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 27, 2020

gnufied reviewed Mar 30, 2020

View reviewed changes

Updating LSO to use digest for 4.3

6468292

huffmanca force-pushed the BZ1781502 branch from 1c2e1fb to 6468292 Compare March 30, 2020 18:03

openshift-ci-robot assigned gnufied Apr 2, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 3, 2020

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 16, 2020

openshift-merge-robot merged commit 9c449a6 into openshift:release-4.3 Apr 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1781502: Updating LSO to use digest for 4.3 #100

Bug 1781502: Updating LSO to use digest for 4.3 #100

huffmanca commented Mar 27, 2020

openshift-ci-robot commented Mar 27, 2020

openshift-ci-robot commented Mar 27, 2020

huffmanca commented Mar 27, 2020

jsafrane commented Mar 30, 2020

gnufied Mar 30, 2020

huffmanca Mar 30, 2020

gnufied Mar 30, 2020

gnufied Mar 30, 2020

huffmanca Mar 30, 2020

gnufied commented Apr 2, 2020

huffmanca commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

gnufied commented Apr 3, 2020

huffmanca commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

huffmanca commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

knobunc commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

eparis commented Apr 16, 2020

openshift-ci-robot commented Apr 16, 2020

huffmanca commented Apr 16, 2020

openshift-ci-robot commented Apr 16, 2020

Bug 1781502: Updating LSO to use digest for 4.3 #100

Bug 1781502: Updating LSO to use digest for 4.3 #100

Conversation

huffmanca commented Mar 27, 2020

openshift-ci-robot commented Mar 27, 2020

openshift-ci-robot commented Mar 27, 2020

huffmanca commented Mar 27, 2020

jsafrane commented Mar 30, 2020

gnufied Mar 30, 2020

Choose a reason for hiding this comment

huffmanca Mar 30, 2020

Choose a reason for hiding this comment

gnufied Mar 30, 2020

Choose a reason for hiding this comment

gnufied Mar 30, 2020

Choose a reason for hiding this comment

huffmanca Mar 30, 2020

Choose a reason for hiding this comment

gnufied commented Apr 2, 2020

huffmanca commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

gnufied commented Apr 3, 2020

huffmanca commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

huffmanca commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

knobunc commented Apr 3, 2020

openshift-ci-robot commented Apr 3, 2020

eparis commented Apr 16, 2020

openshift-ci-robot commented Apr 16, 2020

huffmanca commented Apr 16, 2020

openshift-ci-robot commented Apr 16, 2020