Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1884285: Do not link with -extldflags "-static" #166

Merged
merged 1 commit into from Oct 2, 2020

Conversation

yselkowitz
Copy link
Contributor

This breaks the build on ppc64le, which depends on the external linker
and therefore behaves differently than other architectures.

This breaks the build on ppc64le, which depends on the external linker
and therefore behaves differently than other architectures.
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: This pull request references Bugzilla bug 1884285, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1884285: Do not link with -extldflags "-static"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 2, 2020
@yselkowitz
Copy link
Contributor Author

/assign @huffmanca

@jaypoulz
Copy link

jaypoulz commented Oct 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@manojnkumar
Copy link

/lgtm

@sosiouxme
Copy link
Member

/assign jsafrane

@jsafrane
Copy link
Contributor

jsafrane commented Oct 2, 2020

/approve
(didn't /lgtm mean approval?)

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypoulz, jsafrane, manojnkumar, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit d0d6a25 into openshift:master Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1884285 has been moved to the MODIFIED state.

In response to this:

Bug 1884285: Do not link with -extldflags "-static"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link
Contributor Author

LGTM only implies approved from an approver (owner).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants