Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1937244: remove leading and trailing whitespaces in lsblk output #214

Merged
merged 1 commit into from Mar 20, 2021

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Mar 16, 2021

using strings.Trimspace() on all lsblk outputs to prevent showing local volume discovery with whitespaces. For example, the model in the below discovery results shows whitespace.

 deviceID: /dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol0aae98a99ce01086e
    fstype: ""
    model: 'Amazon Elastic Block Store              '
    path: /dev/nvme1n1
    property: NonRotational
    serial: vol0aae98a99ce01086e
    size: 2147483648
    status:
      state: Available
    type: disk
    vendor: ""
  discoveredTimeStamp: "2021-03-10T01:39:50Z"

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1937244

Signed-off-by: Santosh Pillai sapillai@redhat.com

@sp98 sp98 changed the title remove leading and trailing whitespaces in lsblk output Bug 1937244: remove leading and trailing whitespaces in lsblk output Mar 16, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 16, 2021
@openshift-ci-robot
Copy link
Contributor

@sp98: This pull request references Bugzilla bug 1937244, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1937244: remove leading and trailing whitespaces in lsblk output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
@jsafrane
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Bugzilla bug 1937244, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 19, 2021
@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0856def into openshift:master Mar 20, 2021
@openshift-ci-robot
Copy link
Contributor

@sp98: All pull requests linked via external trackers have merged:

Bugzilla bug 1937244 has been moved to the MODIFIED state.

In response to this:

Bug 1937244: remove leading and trailing whitespaces in lsblk output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants