STOR-977: Refactor reconcilers #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
RomanBednar
force-pushed
the
deleter-refactor
branch
from
6c9ad3a
to
2db7fd0
Compare
|
/retest |
RomanBednar
force-pushed
the
deleter-refactor
branch
5 times, most recently
from
3281c89
to
8f2af82
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
gnufied
reviewed
Aug 25, 2022
gnufied
reviewed
Aug 25, 2022
RuntimeConfig handling is copy pasted in each Reconcile() of deleter, localvolume and localvolumeset controllers. Adding a helper that can be reused in all of them.
RuntimeConfig from sig-storage-local-static-provisioner/pkg/common module contains a mix of values that are static and dynamic. Static values should be set in constructor only and don't change for the entire lifecycle of DeleteReconciler - for example cache, client... Dynamic values could be changed and so they need to be reloaded during reconcile using ReloadRuntimeConfig helper - for example values from config map, node name... Ideally those should be separated but that would require changing the vendored package but still the code can be refactored so the constructor is cleaner and RuntimeConfig is taken out of the constructor. This results in more readable code and better test code since RuntimeConfig is where most fakes are needed for testing.
RomanBednar
force-pushed
the
deleter-refactor
branch
from
8f2af82
to
5435f29
Compare
|
@RomanBednar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This is a minor refactoring, CI should catch regressions |
openshift-ci
bot
added
docs-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new helper function - ReloadRuntimeConfig() that loads runtime config values needed for reconcile loops at one place. This should help make the code cleaner by removing copy-paste code and scattered runtime config changes.
Also adding proper constructors to reconcilers which should improve readability and ease constructing them with fakes in tests.
cc @openshift/storage