[release-4.13] OCPBUGS-17525: prefer wwn, scsi and nvme devices

[openshift-cherrypick-robot]

This is an automated cherry-pick of #417

/assign gnufied

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-16745 has been cloned as Jira Issue OCPBUGS-17525. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-17525: prefer wwn, scsi and nvme devices

In response to this:

This is an automated cherry-pick of #417

/assign gnufied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-17525, which is invalid:

• expected dependent Jira Issue OCPBUGS-16745 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #417

/assign gnufied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gnufied]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Phaow]

/label cherry-pick-approved

[gnufied]

/label backport-risk-assessed

[Phaow]

Pre verify passed on 4.13.0-0.test-2023-08-11-004321-ci-ln-5nzn5qb-latest

1. Install OCP cluster and local storage operator with the pre merged build
2. Attach 1 additional disk to one worker node
3. Create symlink /dev/disk-by-id/wwn-111-222 for the disk
4. Create localvolumeset and wait for the pv created check the use symlink should be the prefer wwn- one.

$ oc get pv/local-pv-18f1d0a8 -oyaml|yq .spec.local
fsType: ext4
path: /mnt/local-storage/mylvs/wwn-111-222
$ oc debug no/ci-ln-5nzn5qb-72292-2n8r2-worker-c-l5vxr

Starting pod/ci-ln-5nzn5qb-72292-2n8r2-worker-c-l5vxr-debug ...
To use host binaries, run `chroot /host`

Pod IP: 10.0.128.4
If you don't see a command prompt, try pressing enter.

sh-4.4# chroot /host
sh-5.1#  ls -l /mnt/local-storage/mylvs/wwn-111-222
lrwxrwxrwx. 1 root root 27 Aug 11 02:51 /mnt/local-storage/mylvs/wwn-111-222 -> /dev/disk/by-id/wwn-111-222
sh-5.1#

[Phaow]

/label qe-approved

[Phaow]

/jira refresh

[openshift-ci-robot]

@Phaow: This pull request references Jira Issue OCPBUGS-17525, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-16745 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-16745 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Phaow]

/jira refresh

[openshift-ci-robot]

@Phaow: This pull request references Jira Issue OCPBUGS-17525, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-16745 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-16745 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
• bug has dependents

Requesting review from QA contact:
/cc @Phaow

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-17525: All pull requests linked via external trackers have merged:

• openshift/local-storage-operator#419

Jira Issue OCPBUGS-17525 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #417

/assign gnufied

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.