Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1803215:Prevent deletion of children objects owned by LocalVolume object #91

Merged
merged 2 commits into from Feb 25, 2020

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Feb 14, 2020

Fix removal of children objects.

Keeping ownerreference to a namespace-scoped object in storageclass
could pollute GC cache and can cause objects to be deleted.

kubernetes/kubernetes#65200
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Bugzilla bug 1803215, which is invalid:

  • expected dependent Bugzilla bug 1803216 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1803215:Prevent deletion of children objects owned by LocalVolume object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2020
@gnufied
Copy link
Member Author

gnufied commented Feb 14, 2020

/cherry-pick release-4.2

@openshift-cherrypick-robot

@gnufied: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Feb 14, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Bugzilla bug 1803215, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 14, 2020
@huffmanca
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, huffmanca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees
Copy link

bparees commented Feb 20, 2020

skipping this one for approval this week due to bug severity and the number of other changes already accepted.

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0f5be2f into openshift:release-4.3 Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

@gnufied: All pull requests linked via external trackers have merged. Bugzilla bug 1803215 has been moved to the MODIFIED state.

In response to this:

Bug 1803215:Prevent deletion of children objects owned by LocalVolume object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gnufied: #91 failed to apply on top of branch "release-4.2":

Applying: Remove orphan storageclasses
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/controller/controller.go
M	test/e2e/localstorage_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/localstorage_test.go
CONFLICT (content): Merge conflict in test/e2e/localstorage_test.go
Auto-merging pkg/controller/controller.go
Patch failed at 0002 Remove orphan storageclasses

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants