Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OU-294: add json pipeline to queries received from korrel8r #167

Conversation

jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Dec 2, 2023

This PR adds a | json formatting pipeline stage to the log queries loaded from korrel8r when correlating an alert. Also adds some tests for checking the link that is added to the alert detail when correlated logs are found

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2023

@jgbernalp: This pull request references OU-294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.15." or "openshift-4.15.", but it targets "Logging 5.8.z" instead.

In response to this:

This PR adds a | json formatting pipeline stage to the log queries loaded from korrel8r when correlating an alert.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jgbernalp
Copy link
Contributor Author

/cherry-pick release-5.8

@openshift-cherrypick-robot

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-5.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-5.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from kyoto and zhuje December 2, 2023 13:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2023
@jgbernalp jgbernalp force-pushed the add-json-pipeline-for-korrel8r-alerts branch 6 times, most recently from c8acc2a to 70bcaa2 Compare December 2, 2023 16:30
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2023

@jgbernalp: This pull request references OU-294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.15." or "openshift-4.15.", but it targets "Logging 5.8.z" instead.

In response to this:

This PR adds a | json formatting pipeline stage to the log queries loaded from korrel8r when correlating an alert. Also adds some tests for checking the link that is added to the alert detail when correlated logs are found

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jgbernalp jgbernalp force-pushed the add-json-pipeline-for-korrel8r-alerts branch from 70bcaa2 to 8560a97 Compare December 4, 2023 08:48
@kyoto
Copy link
Member

kyoto commented Dec 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9bc06af into openshift:main Dec 4, 2023
5 checks passed
@openshift-cherrypick-robot

@jgbernalp: new pull request created: #168

In response to this:

/cherry-pick release-5.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants