-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OU-267: add metrics display to plugin views #171
OU-267: add metrics display to plugin views #171
Conversation
@jgbernalp: This pull request references OU-267 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
da234f1
to
e7853f9
Compare
@jgbernalp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks great! 🤩
Only small comment is that we have increasingly large amount of almost identical code in logs-detail-page.tsx
, logs-dev-page.tsx
and logs-page.tsx
.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, kyoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-5.8 |
@jgbernalp: new pull request created: #177 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the option to display metrics for log queries:
Screen.Recording.2023-12-21.at.12.42.25.mov