Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4041: Update skipRange to allow updating from 5.5 onwards #130

Merged

Conversation

xperimental
Copy link

@xperimental xperimental commented May 4, 2023

What this PR does / why we need it:

This changes the generated bundle to include a skipRange attribute that limits direct updates to only be able from 5.5 onwards.

Which issue(s) this PR fixes:

LOG-4041

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2023

@xperimental: This pull request references LOG-4041 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

This changes the generated bundle to include a skipRange attribute that limits direct updates to only be able from 5.5 onwards.

Which issue(s) this PR fixes:

LOG-4041

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2023

@xperimental: This pull request references LOG-4041 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

This changes the generated bundle to include a skipRange attribute that limits direct updates to only be able from 5.5 onwards.

Which issue(s) this PR fixes:

LOG-4041

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from aminesnow and btaani May 4, 2023 16:53
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@periklis
Copy link

periklis commented May 4, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [periklis,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2023

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 110ac1b into openshift:release-5.7 May 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants