Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.5] LOG-3251: Add valid subscription annotation to metadata #67

Merged
merged 1 commit into from Nov 7, 2022

Conversation

jcantrill
Copy link

@jcantrill jcantrill commented Nov 4, 2022

(cherry picked from commit 3d2aa76)

What this PR does / why we need it:
This PR adds the operators.openshift.io/valid-subscription annotation to the operator metadata.

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/LOG-3251

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@jcantrill jcantrill force-pushed the log3251 branch 2 times, most recently from ffbc910 to b892893 Compare November 4, 2022 16:05
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2022
@xperimental
Copy link

xperimental commented Nov 4, 2022

/retitle LOG-3251 Add valid subscription annotation to metadata

@openshift-ci openshift-ci bot changed the title Adding valid subscription annotation to metadata (#6907) LOG-3251 Add valid subscription annotation to metadata Nov 4, 2022
@xperimental
Copy link

xperimental commented Nov 4, 2022

/retitle LOG-3251: Add valid subscription annotation to metadata

@openshift-ci openshift-ci bot changed the title LOG-3251 Add valid subscription annotation to metadata LOG-3251: Add valid subscription annotation to metadata Nov 4, 2022
@xperimental
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jcantrill,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 447e67c and 2 for PR HEAD 27438fc in total

@jcantrill
Copy link
Author

/cherrypick release-5.4

@openshift-cherrypick-robot

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xperimental
Copy link

/retest lint

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2022

@xperimental: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test ci-index-loki-operator-bundle
  • /test images
  • /test lint
  • /test test
  • /test test-operator

Use /test all to run all jobs.

In response to this:

/retest lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xperimental
Copy link

xperimental commented Nov 4, 2022

/retitle [release-5.5] LOG-3251: Add valid subscription annotation to metadata

@xperimental
Copy link

/retest

@openshift-ci openshift-ci bot changed the title LOG-3251: Add valid subscription annotation to metadata [release-5.5] LOG-3251: Add valid subscription annotation to metadata Nov 4, 2022
@periklis
Copy link

periklis commented Nov 6, 2022

/retest

@periklis
Copy link

periklis commented Nov 7, 2022

Addressed here grafana#7612 but requires backport to release-5.5

@jcantrill
Copy link
Author

/test lint

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@jcantrill: new pull request created: #71

In response to this:

/cherrypick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill deleted the log3251 branch November 7, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants