Update from upstream repository #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the error when an empty label selector is given:
Before:
```sh-session
# Before
$ logcli query "{}"
Error response from server: parse error at line 1, col 2: syntax error: unexpected }, expecting IDENTIFIER
# After
$ logcli query "{}"
Error response from server: parse error : queries require at least one regexp or equality matcher that does not have an empty-compatible value. For instance, app=~".*" does not meet this requirement, but app=~".+" will
```
I fear that might have wider implications, so it would be great to get a
lot of eyes on this.
In theory I think we should remove the restriction on querying all log
streams, but this should maybe discussed in a follow up PR
:slightly_smiling_face:
Co-authored-by: Karsten Jeschkies <karsten.jeschkies@grafana.com>
…duler (#7735) **What this PR does / why we need it**: Gracefully shutdown querier when using query-scheduler This PR is an attempt to fix a bug that my loki cluster is unavailable for logql. The source code and ideas are from mimir of LGTM. Thanks mimir and pr author @pracucci **Which issue(s) this PR fixes**: Fixes #7722 **Special notes for your reviewer**: mimir PR grafana/mimir#1756 grafana/mimir#1767 **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Karsten Jeschkies <k@jeschkies.xyz>
This PR changes the Rate Store to use multi-level maps rather than `tenant+stream-fingerprint` key. Benchmarks: *old* ``` goos: linux goarch: amd64 pkg: github.com/grafana/loki/pkg/distributor cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz BenchmarkRateStore-8 117 10420080 ns/op 3201761 B/op 200025 allocs/op PASS ok github.com/grafana/loki/pkg/distributor 14.646s ``` *new* ``` goos: linux goarch: amd64 pkg: github.com/grafana/loki/pkg/distributor cpu: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz BenchmarkRateStore-8 320 3811906 ns/op 2660 B/op 26 allocs/op ``` *stats* ``` name old time/op new time/op delta RateStore-8 10.7ms ± 8% 4.1ms ± 8% -61.42% (p=0.000 n=10+10) name old alloc/op new alloc/op delta RateStore-8 3.20MB ± 0% 0.00MB ± 0% -99.92% (p=0.000 n=8+9) name old allocs/op new allocs/op delta RateStore-8 200k ± 0% 0k ± 0% -99.99% (p=0.000 n=9+10) ```
…vailable as labels (#7619) **What this PR does / why we need it**: This PR reads the url query parameters included in Heroku drain POST request and creates `__param_<name>` labels similar to how the parameters work with prometheus metrics and metric endpoints as a way to allow setting the true application name when ingesting logs from a Heroku drain. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: The existing `app` field coming from Heroku only specifies application source (either the application itself or Heroku) and thus is insufficient for uniquely identifying a log lines source. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
**What this PR does / why we need it**: **Which issue(s) this PR fixes**: We saw a spike in divide by zero panics in the code introduced in #7769. I was able to reproduce this error via a test that calculates `WeightedParallelism` with a start that's after the end. Not sure if this is possible, but we definitely saw this happening in our ops environment, so something is causing it, and the fix should guard against it in any case. **Special notes for your reviewer**: **Checklist** - [X] Tests updated Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
) Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> **What this PR does / why we need it**: Follow up to #7817 This PR uses `default` branch instead of `inputCh <- work` to make sure we are writing to closed `inputCh`. Gist is, `default` run [only when none of the branch is ready](https://go.dev/tour/concurrency/6). which makes more sense rather than to have `inputCh <- work` (writing to closed channel on the branch condition) These can be explained by these two tiny snippets. * [with `default`](https://go.dev/play/p/-FspbTZd20I) * [without `default`](https://go.dev/play/p/Ag4WznOaEq0) **Which issue(s) this PR fixes**: Fixes #NA **Special notes for your reviewer**: We already have test `TestMemcached_fetchKeysBatched` to catch this behaviour. In fact this test caught this probabilistic behaviour in some CI failures. [here ](https://drone.grafana.net/grafana/loki/17853/3/4) and[ here](https://drone.grafana.net/grafana/loki/17854/3/4) Thanks @DylanGuedes for catching this CI failures. **Checklist** Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
**What this PR does / why we need it**: For better observability of query retries. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
This PR just adds tenant information so some of our per-stream-rate-limit metrics.
**What this PR does / why we need it**: Bumps Loki to 2.7.0 and GEL to 1.6.0 in the helm chart.
faillint needs an update for Go 1.19 where it fails unexpectedly. First observed in #7826. See fatih/faillint#36
Follow up on #7848, where the Drone config needed to be updated as well
Closes #7811, which is needed for Grafana Agent to update to v2.40 and add support for native histograms. I did not add support for native histograms to Loki, sorry :)
**What this PR does / why we need it**: Add one additional bucket (value=1) to the `rate_store_stream_shards`. By jumping from 0 to 2 we can't distinguish between streams that were minimally sharded (shards=2) to non-sharded ones (shards=1).
**Context:** #7359 implement multi tenancy for the alertmanager config. However, the behavior of the per-tenant alertmanager config is erroneous, as it tries to merge the global alertmanager config with the per-tenant config. This does not work because there is no way of knowing if certain values were set by the user or if they were undefined and have the default Golang zero value (typically booleans). This PR changes the behavior of the alertmanager config to override all the configuration instead of trying to merge the global config with the per-tenant config. It also applies default values when appropriate.
**What this PR does / why we need it**: Fixes a typo in configuration.md, improves reader clarify and confidence **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
This change fixes a small typo in case of a missing space.
**What this PR does / why we need it**: The 'grafana/loki-build-image' version was not specified for the promtail-debug docker image, resulting in a ~6 month old 'latest' image as a build image. Updating this resulted in one more change: the newer version has a different location for the 'dlv' binary. The promtail-debug image would also hang waiting for a connection when ran, this adds the same flag, `--continue`, as added to the loki debug file in #1372. **Special notes for your reviewer**: I was interested in using the `-server.profiling_enabled=true` flag, to enable pprof endpoints, and scrape with phlare. This flag is not available in the non-debug version. Therefore I do not really care for attaching a debugger right away. Open to removing that change though. **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
…7850) Bumps [cloud.google.com/go/bigtable](https://github.com/googleapis/google-cloud-go) from 1.3.0 to 1.18.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/googleapis/google-cloud-go/releases">cloud.google.com/go/bigtable's releases</a>.</em></p> <blockquote> <h2>bigtable: v1.18.1</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/bigtable/v1.18.0...bigtable/v1.18.1">1.18.1</a> (2022-12-02)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>bigtable:</strong> downgrade some dependencies (<a href="https://github.com/googleapis/google-cloud-go/commit/754015236d5af7c82a75da218b71a87b9ead6eb5">7540152</a>)</li> </ul> <h2>bigtable: v1.18.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/bigtable/v1.17.0...bigtable/v1.18.0">1.18.0</a> (2022-11-10)</h2> <h3>Features</h3> <ul> <li><strong>bigtable:</strong> Add support for request stats (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/6991">#6991</a>) (<a href="https://github.com/googleapis/google-cloud-go/commit/609421e87ff25971f3fc29e15dbcdaa7fba02d11">609421e</a>)</li> </ul> <h2>securitycenter: v1.17.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/securitycenter/v1.16.0...securitycenter/v1.17.0">1.17.0</a> (2022-11-16)</h2> <h3>Features</h3> <ul> <li><strong>securitycenter:</strong> Add files field to finding's list of attributes (<a href="https://github.com/googleapis/google-cloud-go/commit/ac0c5c21221e8d055e6b8b1c473600c58e306b00">ac0c5c2</a>)</li> </ul> <h2>securitycenter: v1.16.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/securitycenter/v1.15.0...securitycenter/v1.16.0">1.16.0</a> (2022-11-03)</h2> <h3>Features</h3> <ul> <li><strong>securitycenter:</strong> rewrite signatures in terms of new location (<a href="https://github.com/googleapis/google-cloud-go/commit/3c4b2b34565795537aac1661e6af2442437e34ad">3c4b2b3</a>)</li> </ul> <h2>compute: v1.13.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/compute/v1.12.1...compute/v1.13.0">1.13.0</a> (2022-12-01)</h2> <h3>Features</h3> <ul> <li><strong>compute:</strong> start generating stubs dir (<a href="https://github.com/googleapis/google-cloud-go/commit/5d0b405033f55023825ef90e5c539f1bcf2ddedb">5d0b405</a>)</li> <li><strong>compute:</strong> Update Compute Engine API to revision 20221101 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/751">#751</a>) (<a href="https://github.com/googleapis/google-cloud-go/commit/7231644e71f05abc864924a0065b9ea22a489180">7231644</a>)</li> </ul> <h2>documentai: v1.13.0</h2> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.12.0...documentai/v1.13.0">1.13.0</a> (2022-12-01)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added field_mask field in DocumentOutputConfig.GcsOutputConfig in document_io.proto (<a href="https://github.com/googleapis/google-cloud-go/commit/2a0b1aeb1683222e6aa5c876cb945845c00cef79">2a0b1ae</a>)</li> </ul> <h2>documentai: v1.12.0</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/googleapis/google-cloud-go/blob/main/documentai/CHANGES.md">cloud.google.com/go/bigtable's changelog</a>.</em></p> <blockquote> <h1>Changes</h1> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.12.0...documentai/v1.13.0">1.13.0</a> (2022-12-01)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added field_mask field in DocumentOutputConfig.GcsOutputConfig in document_io.proto (<a href="https://github.com/googleapis/google-cloud-go/commit/2a0b1aeb1683222e6aa5c876cb945845c00cef79">2a0b1ae</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.11.0...documentai/v1.12.0">1.12.0</a> (2022-11-16)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added TrainProcessorVersion, EvaluateProcessorVersion, GetEvaluation, and ListEvaluations v1beta3 APIs feat: added evaluation.proto feat: added document_schema field in ProcessorVersion processor.proto feat: added image_quality_scores field in Document.Page in document.proto feat: added font_family field in Document.Style in document.proto (<a href="https://github.com/googleapis/google-cloud-go/commit/ac0c5c21221e8d055e6b8b1c473600c58e306b00">ac0c5c2</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.10.0...documentai/v1.11.0">1.11.0</a> (2022-11-09)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> added font_family to document.proto feat: added ImageQualityScores message to document.proto feat: added PropertyMetadata and EntityTypeMetadata to document_schema.proto (<a href="https://github.com/googleapis/google-cloud-go/commit/9c5d6c857b9deece4663d37fc6c834fd758b98ca">9c5d6c8</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.9.0...documentai/v1.10.0">1.10.0</a> (2022-11-03)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> rewrite signatures in terms of new location (<a href="https://github.com/googleapis/google-cloud-go/commit/3c4b2b34565795537aac1661e6af2442437e34ad">3c4b2b3</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.8.0...documentai/v1.9.0">1.9.0</a> (2022-10-25)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> start generating stubs dir (<a href="https://github.com/googleapis/google-cloud-go/commit/de2d18066dc613b72f6f8db93ca60146dabcfdcc">de2d180</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.7.0...documentai/v1.8.0">1.8.0</a> (2022-09-21)</h2> <h3>Features</h3> <ul> <li><strong>documentai:</strong> rewrite signatures in terms of new types for betas (<a href="https://github.com/googleapis/google-cloud-go/commit/9f303f9efc2e919a9a6bd828f3cdb1fcb3b8b390">9f303f9</a>)</li> </ul> <h2><a href="https://github.com/googleapis/google-cloud-go/compare/documentai/v1.6.0...documentai/v1.7.0">1.7.0</a> (2022-09-19)</h2> <h3>Features</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/googleapis/google-cloud-go/commit/4ec9eed76b7f06c91703590fb25c596fc9536d5d"><code>4ec9eed</code></a> chore: release storage 1.18.1 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4984">#4984</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/e17334d1fe7645d89d14ae7148313498b984dfbb"><code>e17334d</code></a> fix(storage): don't assume auth from a client option (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4982">#4982</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/0f7457c6a9eff6465cfcf587aa8d60eb8b83dcaa"><code>0f7457c</code></a> chore(all): auto-regenerate gapics (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4977">#4977</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/d28ba7868b1a1f1a142147af3b5cdc6129bed505"><code>d28ba78</code></a> test(spanner): fix flaky TestIntegration_StartBackupOperation test (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4978">#4978</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/5edfd3693b2c4f76e04618d6453b486847a757da"><code>5edfd36</code></a> chore: release spanner 1.26.0 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4751">#4751</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/090cc3ae0f8747a14cc904fc6d429e2f5379bb03"><code>090cc3a</code></a> chore(all): auto-regenerate gapics (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4972">#4972</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/acece394a38843f4355a82d0abab1e41994eca12"><code>acece39</code></a> chore(all): update all (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4971">#4971</a>)</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/309b59e583d1bf0dd9ffe84223034eb8a2975d47"><code>309b59e</code></a> fix(internal/godocfx): only put TOC status on mod if all pkgs have same statu...</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/3441e1f1b6b161c36cb14818eacd53af44c18a8a"><code>3441e1f</code></a> test(bigtable): abbrviate instance and cluster names to avoid length overrun ...</li> <li><a href="https://github.com/googleapis/google-cloud-go/commit/26dff4fca81638e838a61d5c83991e41cefd1286"><code>26dff4f</code></a> chore: release storage 1.18.0 (<a href="https://github-redirect.dependabot.com/googleapis/google-cloud-go/issues/4951">#4951</a>)</li> <li>Additional commits viewable in <a href="https://github.com/googleapis/google-cloud-go/compare/dlp/v1.3.0...storage/v1.18.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Commit 30caf14 introduced a regression ending up in generating no PrometheusRule alerts. That was fixed in commit 433d883 but no releases were done. Bump version to have a release about it. **What this PR does / why we need it**: **Which issue(s) this PR fixes**: Should hopefully fix a request done by @xinbinhuang - who spotted and fixed this problem, thanks! - in #7860. I think it is important to tag a release ASAP because stopping having alerts can be a regression in possible production environments. **Special notes for your reviewer**: I have no idea if that will force to release a 3.6.1 Helm release without doing any tag or similar, sorry! I have tried to skim documentation about that and I have skimmed `.github/workflows/helm-release.yaml` and `grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main` and I think that this will create a tag... but I'm not super-sure about that! If I've missed anything please let me know! Thanks! **Checklist** - [x] Reviewed the `CONTRIBUTING.md` guide - [ ] Documentation added - [ ] Tests updated - [x] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md`
…for query sharding (#7880) **What this PR does / why we need it**: We disable query sharding when a query touches multiple schema configs since they might have different sharding factors and might handle sharding differently. This check was done purely on the start and end time of the query without considering `range` and `offset`, which would change the length of the actual data being queried. Besides being incorrect, it also causes us to fail queries when migrating between tsdb and non-tsdb stores since both handle query sharding differently. For e.g., if the prev schema is `boltdb-shipper` and starting today, `tsdb` index is being used, so if we do a query `sum(rate({foo="bar"}[24h])` even with start and end within `tsdb` range, we will fail the query with error `incompatible index shard` if dynamic sharding goes with shard factor other than `32`(default shard factor in ingester for inverted index). The reason being the `range` here is `24h` which causes us to process data from previous schema as well. This PR takes care of the issue by factoring in `range` and `offset` in the queries while looking for schema config for query sharding. **Checklist** - [x] `CHANGELOG.md` updated
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.1.0 to 0.4.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/crypto/commit/eb2c406296d40946e2c0c72a50d34527a3987fff"><code>eb2c406</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/crypto/commit/2c476679df9a5c6279ec05b48165f4bed48b792e"><code>2c47667</code></a> cryptobyte: add support for ReadASN1Integer into []byte</li> <li><a href="https://github.com/golang/crypto/commit/0ec7e8322c090be3a94a90823b9ae085541f5f1e"><code>0ec7e83</code></a> internal/wycheproof: update Go 1.20 crypto/ecdh API</li> <li><a href="https://github.com/golang/crypto/commit/6fad3dfc18918c2ac9c112e46b32473bd2e5e2f9"><code>6fad3df</code></a> ssh: support rsa-sha2-256/512 on the server side</li> <li><a href="https://github.com/golang/crypto/commit/21d60a152191de71c82a8101779e876bb03773b7"><code>21d60a1</code></a> all: remove redundant type conversion</li> <li><a href="https://github.com/golang/crypto/commit/183a9b70cc805eca27c9474ce65820b468a28795"><code>183a9b7</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/crypto/commit/334521b960a2a4412e9e7486c89e9981cf160ddb"><code>334521b</code></a> ssh: fix typo</li> <li><a href="https://github.com/golang/crypto/commit/a3485e174077e5296d3d4a43ca31d2d21b40be2c"><code>a3485e1</code></a> all: use math/bits.RotateLeft</li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.1.0...v0.4.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
**What this PR does / why we need it**: The sizing tool should help to find a good cluster sizing when starting out with Loki. It's a dynamic form withing the documentation.  This pull request will be followed by help on hover. **Special notes for your reviewer**: **Checklist** - [ ] Reviewed the `CONTRIBUTING.md` guide - [x] Documentation added - [x] Tests updated - [ ] `CHANGELOG.md` updated - [ ] Changes that require user attention or interaction to upgrade are documented in `docs/sources/upgrading/_index.md` Co-authored-by: Karsten Jeschkies <karste.jeschkies@grafana.com>
**What this PR does / why we need it**: Prepares changelog and release notes for 2.7.1 release. Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
Limit stage can now takes optional `by_label_name` param, which tracks distinct values of that label and ratelimit entries independently. Log lines without expected label are not considered for ratelimiting and passed to the next pipeline stage.
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: periklis, xperimental The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@periklis: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.