Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-24480: Allow setting overprovision ratio to 1 #522

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/lvmcluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ type ThinPoolConfig struct {

// OverProvisionRatio is the factor by which additional storage can be provisioned compared to
// the available storage in the thin pool.
// +kubebuilder:validation:Minimum=2
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:Required
// +required
OverprovisionRatio int `json:"overprovisionRatio"`
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ spec:
description: OverProvisionRatio is the factor by which
additional storage can be provisioned compared to
the available storage in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ spec:
description: OverProvisionRatio is the factor by which additional
storage can be provisioned compared to the available storage
in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ spec:
description: OverProvisionRatio is the factor by which
additional storage can be provisioned compared to
the available storage in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ spec:
description: OverProvisionRatio is the factor by which additional
storage can be provisioned compared to the available storage
in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
Expand Down
2 changes: 1 addition & 1 deletion doc/design/thin_pool.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ The LVMO will create a thin-pool LV in the volume group in order to create thinl

+ // OverProvisionRatio represents the ratio of overprovision that can
+ // be allowed on thin pools
+ // +kubebuilder:validation:Minimum=2
+ // +kubebuilder:validation:Minimum=1
+ OverprovisionRatio int `json:"overprovisionRatio,omitempty"`
}

Expand Down