Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2110505: revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level #1044

Merged
merged 1 commit into from Jul 26, 2022
Merged

Bug 2110505: revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level #1044

merged 1 commit into from Jul 26, 2022

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jul 25, 2022 •
edited

revert of #1031

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@bparees: This pull request references Bugzilla bug 2101880, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.12.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 2101880 to depend on a bug targeting a release in 4.12.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty
LalatenduMohanty approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@bparees
Copy link
Contributor Author

bparees commented Jul 25, 2022

/hold

not merging this until at a minimum we have some verification from @sdodson
we also need the master version of the PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@bparees: This pull request references Bugzilla bug 2101880, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.12.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 2101880 to depend on a bug targeting a release in 4.12.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty
LalatenduMohanty approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bparees bparees changed the title revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level Bug 2110505: revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@bparees: This pull request references Bugzilla bug 2110505, which is invalid:

  • expected dependent Bugzilla bug 2108858 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Bugzilla bug 2110501 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2110505: revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 25, 2022
@bparees
Copy link
Contributor Author

bparees commented Jul 25, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@bparees bparees added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 25, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD bf0357d and 8 for PR HEAD 401fe30 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD bf0357d and 7 for PR HEAD 401fe30 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@bparees: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack 401fe30 link false /test e2e-openstack
ci/prow/e2e-vsphere-upgrade 401fe30 link false /test e2e-vsphere-upgrade
ci/prow/e2e-vsphere 401fe30 link false /test e2e-vsphere
ci/prow/e2e-aws-disruptive 401fe30 link false /test e2e-aws-disruptive
ci/prow/e2e-azure 401fe30 link false /test e2e-azure
ci/prow/e2e-vsphere-operator 401fe30 link false /test e2e-vsphere-operator
ci/prow/e2e-libvirt 401fe30 link false /test e2e-libvirt
ci/prow/e2e-azure-operator 401fe30 link false /test e2e-azure-operator
ci/prow/e2e-metal-ipi-ovn-dualstack 401fe30 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-gcp-operator 401fe30 link false /test e2e-gcp-operator
ci/prow/e2e-metal-ipi-virtualmedia 401fe30 link false /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4e3e83c into release-4.11 Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@bparees: All pull requests linked via external trackers have merged:

Bugzilla bug 2110505 has been moved to the MODIFIED state.

In response to this:

Bug 2110505: revert: Bug 2101880: operator NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@LalatenduMohanty LalatenduMohanty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bparees @JoelSpeed @openshift-ci-robot @LalatenduMohanty @openshift-merge-robot