Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for machineset tests #1091

Merged

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Nov 29, 2022

Currently, when running in CI, machineset tests sometimes fail with timeout error.

• Failure in Spec Teardown (AfterEach) [12.059 seconds]
MachineSet Reconciler
/go/src/github.com/openshift/machine-api-operator/pkg/controller/machineset/machineset_controller_test.go:31
  Should reconcile a MachineSet [AfterEach]
  /go/src/github.com/openshift/machine-api-operator/pkg/controller/machineset/machineset_controller_test.go:77
  Timed out after 10.000s.

To prevent this we increase the timeout to 20 seconds.

Currently, when running in CI, machineset tests sometimes fail with
timeout error. To prevent this we increase the timeout to 20 seconds.
Copy link
Contributor

@lobziik lobziik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7dd991f and 2 for PR HEAD dfe775b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

@Fedosin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator dfe775b link false /test e2e-azure-operator
ci/prow/e2e-metal-ipi-upgrade dfe775b link false /test e2e-metal-ipi-upgrade
ci/prow/e2e-vsphere-ovn-upgrade dfe775b link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-gcp-ovn dfe775b link false /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn dfe775b link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack dfe775b link false /test e2e-openstack
ci/prow/e2e-libvirt dfe775b link false /test e2e-libvirt
ci/prow/e2e-metal-ipi-ovn-dualstack dfe775b link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0b6b598 into openshift:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants