Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[release-4.12] OCPBUGS-5413: Append annotations from machine template spec to the node" #1108

Conversation

deepsm007
Copy link

Reverts #1104 ; tracked by https://issues.redhat.com/browse/TRT-773
TRT suspects this PR as being a possible cause of a recent payload regression. We are floating this revert to perform additional testing.

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-upgrade/1613567375997669376

Holding pending confirmation:
/hold

CC: @RadekManak

@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

@deepsm007: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Revert "[release-4.12] OCPBUGS-5413: Append annotations from machine template spec to the node"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

@deepsm007: This pull request references Jira Issue OCPBUGS-5413, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1104 ; tracked by https://issues.redhat.com/browse/TRT-773
TRT suspects this PR as being a possible cause of a recent payload regression. We are floating this revert to perform additional testing.

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-upgrade/1613567375997669376

Holding pending confirmation:
/hold

CC: @RadekManak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval by writing /assign @elmiko in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepsm007
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

@deepsm007: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/47d30450-92b9-11ed-90e0-6104733b30e9-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

@deepsm007: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 8490038 link false /test e2e-gcp-ovn
ci/prow/e2e-vsphere-operator 8490038 link false /test e2e-vsphere-operator
ci/prow/e2e-vsphere-ovn 8490038 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack 8490038 link false /test e2e-openstack
ci/prow/e2e-gcp-operator 8490038 link false /test e2e-gcp-operator
ci/prow/e2e-metal-ipi-ovn-ipv6 8490038 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-upgrade 8490038 link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-nutanix 8490038 link false /test e2e-nutanix
ci/prow/e2e-libvirt 8490038 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

I've left a comment on the TRT ticket but I don't think this is going to be the source of the bug that's caused the upgrades to start failing

@deepsm007 deepsm007 closed this Jan 13, 2023
@openshift-ci-robot
Copy link
Contributor

@deepsm007: This pull request references Jira Issue OCPBUGS-5413. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Reverts #1104 ; tracked by https://issues.redhat.com/browse/TRT-773
TRT suspects this PR as being a possible cause of a recent payload regression. We are floating this revert to perform additional testing.

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-upgrade/1613567375997669376

Holding pending confirmation:
/hold

CC: @RadekManak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants