OCPBUGS-13132: Golang update to 1.20

[JoelSpeed]

This supersedes #1137 since it is causing issues with the linter. This PR includes the changes from the bump but also bumps golangci-lint to v1.52.2 to include fixes that make it work with Go 1.20

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-13132, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This supersedes #1137 since it is causing issues with the linter. This PR includes the changes from the bump but also bumps golangci-lint to v1.52.2 to include fixes that make it work with Go 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

Noticed the OOM issues with the linter on my machine too.
+1 for fixing it.
/lgtm

[damdo]

/lgtm

[damdo]

/retest

[damdo]

/retest

[damdo]

/retest

[openshift-ci]

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack	ff98c98	link	false	/test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia	ff98c98	link	false	/test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-sdn	ff98c98	link	false	/test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@JoelSpeed: Jira Issue OCPBUGS-13132: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/machine-api-operator#1137 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13132 has not been moved to the MODIFIED state.

In response to this:

This supersedes #1137 since it is causing issues with the linter. This PR includes the changes from the bump but also bumps golangci-lint to v1.52.2 to include fixes that make it work with Go 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.