Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25734: Add Snyk file to exclude vendor directory on scan #1193

Merged

Conversation

racheljpg
Copy link
Contributor

Hello! This is a PR to add a snyk file to exclude the vendors folder while scanning the repo. Thanks!

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 20, 2023
@openshift-ci-robot
Copy link
Contributor

@racheljpg: This pull request references Jira Issue OCPBUGS-25734, which is invalid:

  • expected dependent Jira Issue OCPBUGS-25735 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Hello! This is a PR to add a snyk file to exclude the vendors folder while scanning the repo. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from nrb and vincepri December 20, 2023 14:58
Copy link
Contributor

openshift-ci bot commented Dec 20, 2023

@racheljpg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-operator d6dbadb link false /test e2e-vsphere-operator
ci/prow/e2e-azure-operator d6dbadb link false /test e2e-azure-operator
ci/prow/e2e-vsphere-ovn-serial d6dbadb link false /test e2e-vsphere-ovn-serial
ci/prow/e2e-metal-ipi-ovn-dualstack d6dbadb link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-vsphere-ovn-upgrade d6dbadb link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-vsphere-ovn d6dbadb link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack d6dbadb link false /test e2e-openstack
ci/prow/e2e-gcp-ovn d6dbadb link false /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm
/label backport-risk-assessed
/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

@JoelSpeed: This pull request references Jira Issue OCPBUGS-25734, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25735 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-25735 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/approve
/lgtm
/label backport-risk-assessed
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 21, 2023
@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@sunzhaohua2
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 22, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 9e4c3a3 into openshift:release-4.15 Dec 22, 2023
18 of 26 checks passed
@openshift-ci-robot
Copy link
Contributor

@racheljpg: Jira Issue OCPBUGS-25734: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25734 has been moved to the MODIFIED state.

In response to this:

Hello! This is a PR to add a snyk file to exclude the vendors folder while scanning the repo. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-operator-container-v4.15.0-202312220332.p0.g9e4c3a3.assembly.stream for distgit ose-machine-api-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants