SPLAT-1638: Added multi vCenter support #1241
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-1638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@vr4manta: This pull request references SPLAT-1638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#8221
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/652f0350-144a-11ef-979c-c7c5c682dc9f-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#8221
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3383e5f0-1486-11ef-8537-9fe6a0f164a0-0 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
vr4manta
force-pushed
the
SPLAT-1638
branch
3 times, most recently
from
cd2bfdf
to
06553d1
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
/test unit |
|
/test unit |
|
/test all |
|
/test e2e-vsphere-ovn |
|
@vr4manta: This pull request references SPLAT-1638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
|
@vr4manta: This pull request references SPLAT-1638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pkg/controller/vsphere/util_test.go
Outdated
| testInsecureFlag = "1" | ||
| testInsecureFlag = true |
There was a problem hiding this comment.
Is there a change in the accepted values?
There was a problem hiding this comment.
no, its a boolean that comes out of the object, not a "1". below you can see "1" is still used in creating ini file.
vr4manta
force-pushed
the
SPLAT-1638
branch
2 times, most recently
from
d7714c4
to
5c4cc08
Compare
|
@vr4manta: This pull request references SPLAT-1638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/assign @JoelSpeed |
|
/test e2e-vsphere-ovn |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#8221
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bad92410-1dba-11ef-9194-5efcb977bc4b-0 |
|
@vr4manta: This pull request references SPLAT-1638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit f280849
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-api-operator-container-v4.17.0-202405310013.p0.gf280849.assembly.stream.el9 for distgit ose-machine-api-operator. |
SPLAT-1638
Changes
Dependencies
Notes
I currently have same changes as https://github.com/openshift/machine-api-operator/pull/1250/files due to hitting the same things earlier. Talked to Joel and having these done as separate PR.